]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
PCI: mediatek: Silence 'set affinity failed' warning
authorMarek Vasut <marek.vasut+renesas@mailbox.org>
Tue, 23 Jul 2024 13:27:07 +0000 (15:27 +0200)
committerBjorn Helgaas <bhelgaas@google.com>
Mon, 29 Jul 2024 17:46:35 +0000 (12:46 -0500)
Use MSI_FLAG_NO_AFFINITY, which keeps .irq_set_affinity() unset and allows
migrate_one_irq() to exit right away, without warnings like this:

  IRQ...: set affinity failed(-22)

Remove the .irq_set_affinity() implementation that is no longer needed.

Link: https://lore.kernel.org/r/20240723132958.41320-8-marek.vasut+renesas@mailbox.org
Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
[bhelgaas: commit log]
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Acked-by: Jianjun Wang <jianjun.wang@mediatek.com>
Acked-by: Thomas Gleixner <tglx@linutronix.de>
drivers/pci/controller/pcie-mediatek.c

index 7fc0d7709b7fbd109523186ddc045b7466cb394f..9be3cebd862e28d86ca85c07c9655d2e01a7f49c 100644 (file)
@@ -407,12 +407,6 @@ static void mtk_compose_msi_msg(struct irq_data *data, struct msi_msg *msg)
                (int)data->hwirq, msg->address_hi, msg->address_lo);
 }
 
-static int mtk_msi_set_affinity(struct irq_data *irq_data,
-                               const struct cpumask *mask, bool force)
-{
-        return -EINVAL;
-}
-
 static void mtk_msi_ack_irq(struct irq_data *data)
 {
        struct mtk_pcie_port *port = irq_data_get_irq_chip_data(data);
@@ -424,7 +418,6 @@ static void mtk_msi_ack_irq(struct irq_data *data)
 static struct irq_chip mtk_msi_bottom_irq_chip = {
        .name                   = "MTK MSI",
        .irq_compose_msi_msg    = mtk_compose_msi_msg,
-       .irq_set_affinity       = mtk_msi_set_affinity,
        .irq_ack                = mtk_msi_ack_irq,
 };
 
@@ -486,8 +479,8 @@ static struct irq_chip mtk_msi_irq_chip = {
 };
 
 static struct msi_domain_info mtk_msi_domain_info = {
-       .flags  = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS |
-                  MSI_FLAG_PCI_MSIX),
+       .flags  = MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS |
+                 MSI_FLAG_NO_AFFINITY | MSI_FLAG_PCI_MSIX,
        .chip   = &mtk_msi_irq_chip,
 };