]> git.ipfire.org Git - thirdparty/git.git/commitdiff
t98xx: mark Perforce tests as memory-leak free
authorPatrick Steinhardt <ps@pks.im>
Wed, 31 Jul 2024 10:37:56 +0000 (12:37 +0200)
committerJunio C Hamano <gitster@pobox.com>
Wed, 31 Jul 2024 17:05:18 +0000 (10:05 -0700)
All the Perforce tests are free of memory leaks. This went unnoticed
because most folks do not have p4 and p4d installed on their computers.
Consequently, given that the prerequisites for running those tests
aren't fulfilled, `TEST_PASSES_SANITIZE_LEAK=check` won't notice that
those tests are indeed memory leak free.

Mark those tests accordingly.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
35 files changed:
t/t9800-git-p4-basic.sh
t/t9801-git-p4-branch.sh
t/t9802-git-p4-filetype.sh
t/t9803-git-p4-shell-metachars.sh
t/t9804-git-p4-label.sh
t/t9805-git-p4-skip-submit-edit.sh
t/t9806-git-p4-options.sh
t/t9808-git-p4-chdir.sh
t/t9809-git-p4-client-view.sh
t/t9810-git-p4-rcs.sh
t/t9811-git-p4-label-import.sh
t/t9812-git-p4-wildcards.sh
t/t9813-git-p4-preserve-users.sh
t/t9814-git-p4-rename.sh
t/t9815-git-p4-submit-fail.sh
t/t9816-git-p4-locked.sh
t/t9817-git-p4-exclude.sh
t/t9818-git-p4-block.sh
t/t9819-git-p4-case-folding.sh
t/t9820-git-p4-editor-handling.sh
t/t9821-git-p4-path-variations.sh
t/t9822-git-p4-path-encoding.sh
t/t9823-git-p4-mock-lfs.sh
t/t9825-git-p4-handle-utf16-without-bom.sh
t/t9826-git-p4-keep-empty-commits.sh
t/t9827-git-p4-change-filetype.sh
t/t9828-git-p4-map-user.sh
t/t9829-git-p4-jobs.sh
t/t9830-git-p4-symlink-dir.sh
t/t9831-git-p4-triggers.sh
t/t9832-unshelve.sh
t/t9833-errors.sh
t/t9834-git-p4-file-dir-bug.sh
t/t9835-git-p4-metadata-encoding-python2.sh
t/t9836-git-p4-metadata-encoding-python3.sh

index 0816763e46639cc19bb5e15598303638c992a2c7..3e6dfce24833a061acff8babe5135885708aab41 100755 (executable)
@@ -5,6 +5,7 @@ test_description='git p4 tests'
 GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
 export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./lib-git-p4.sh
 
 test_expect_success 'start p4d' '
index c598011635ac2f44d0764acaf1ba7c53f569514c..cdbfacc727a7c676cb9a31f3a14019461feea4f4 100755 (executable)
@@ -5,6 +5,7 @@ test_description='git p4 tests for p4 branches'
 GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
 export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./lib-git-p4.sh
 
 test_expect_success 'start p4d' '
index df01a5d3389861faf2110520678778e48f3ec970..1bc48305b017897a143f3d3b660c506e8f1f423e 100755 (executable)
@@ -2,6 +2,7 @@
 
 test_description='git p4 filetype tests'
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./lib-git-p4.sh
 
 test_expect_success 'start p4d' '
index 2913277013da56e98b9ad8b6ec3ea47ccbace103..ab7fe16266872c83235e4cd083ea2e44b0083567 100755 (executable)
@@ -2,6 +2,7 @@
 
 test_description='git p4 transparency to shell metachars in filenames'
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./lib-git-p4.sh
 
 test_expect_success 'start p4d' '
index 32364571063d4c6001105d0929ca81fe50e2a87c..c8963fd3980e0eedff9530d0e9a9d32862b9b05e 100755 (executable)
@@ -2,6 +2,7 @@
 
 test_description='git p4 label tests'
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./lib-git-p4.sh
 
 test_expect_success 'start p4d' '
index 90ef647db7e610b825cc92d51ee2a5379dcf05b3..72dce3d2b46f4dd103baefb7a833917e60b151b0 100755 (executable)
@@ -2,6 +2,7 @@
 
 test_description='git p4 skipSubmitEdit config variables'
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./lib-git-p4.sh
 
 test_expect_success 'start p4d' '
index c26d29743307b5546d80e9c6d0cd16442a43a421..e4ce44ebf3783be3a373557cdcacec6fb20416c2 100755 (executable)
@@ -5,6 +5,7 @@ test_description='git p4 options'
 GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
 export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./lib-git-p4.sh
 
 test_expect_success 'start p4d' '
index 58a9b3b71e6d88dfc9e3086fb515362e7c31e34a..342f7f3d4a09d20af8e9f00727f91fb5523e9e96 100755 (executable)
@@ -2,6 +2,7 @@
 
 test_description='git p4 relative chdir'
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./lib-git-p4.sh
 
 test_expect_success 'start p4d' '
index 9c9710d8c7b8713f4dfb0cfacd0c07ce71a71226..f33fdea889edc339267ff4bb7bf7d94809897952 100755 (executable)
@@ -2,6 +2,7 @@
 
 test_description='git p4 client view'
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./lib-git-p4.sh
 
 test_expect_success 'start p4d' '
index 5fe83315ecd57a81055bdcf2d055122ec53fd3b8..15e32c9f353a73b47b7e2aab0be3636b3e5bfe5b 100755 (executable)
@@ -2,6 +2,7 @@
 
 test_description='git p4 rcs keywords'
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./lib-git-p4.sh
 
 CP1252="\223\224"
index 5ac5383fb717153b893302eba7952b6962de70a2..52a4b0af811294406b8478df161abe37c32ff0cb 100755 (executable)
@@ -5,6 +5,7 @@ test_description='git p4 label tests'
 GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
 export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./lib-git-p4.sh
 
 test_expect_success 'start p4d' '
index 254a7c244698a0140d6f5605d3013f72d9775310..46aa5fd56c7706ab23651112c40919cbdad2b354 100755 (executable)
@@ -2,6 +2,7 @@
 
 test_description='git p4 wildcards'
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./lib-git-p4.sh
 
 test_expect_success 'start p4d' '
index fd018c87a80636d7bb286fe596f299bbbbe6828b..0efea28da2cb9d6f09a024e174fc0ff50a303872 100755 (executable)
@@ -2,6 +2,7 @@
 
 test_description='git p4 preserve users'
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./lib-git-p4.sh
 
 test_expect_success 'start p4d' '
index 2a9838f37fe293738a75e626041531456c274f72..00df6ebd3bdc03f3ebef6cd20af66325e6ee713a 100755 (executable)
@@ -2,6 +2,7 @@
 
 test_description='git p4 rename'
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./lib-git-p4.sh
 
 test_expect_success 'start p4d' '
index c766fd159f14b69eb46f9dc9bfb4357fdd7a5e34..92ef9d8c242559b9d7b90b975d9d9905922ef24a 100755 (executable)
@@ -2,6 +2,7 @@
 
 test_description='git p4 submit failure handling'
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./lib-git-p4.sh
 
 test_expect_success 'start p4d' '
index 5e904ac80d85226a74296774ef4279369da15d4a..e687fbc25f60f5f4e8d4e540f99e072370d9d209 100755 (executable)
@@ -2,6 +2,7 @@
 
 test_description='git p4 locked file behavior'
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./lib-git-p4.sh
 
 test_expect_success 'start p4d' '
index ec3d937c6a73bb8d89de51839af4bba4c3a73910..3deb334fed1c6aa068861e4e1c196e9c0edf39f1 100755 (executable)
@@ -2,6 +2,7 @@
 
 test_description='git p4 tests for excluded paths during clone and sync'
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./lib-git-p4.sh
 
 test_expect_success 'start p4d' '
index de591d875c2bbc94fd1c9b093867d23f3ce1b00c..091bb72bdb62bde767de2ae346dc361de9e2f9be 100755 (executable)
@@ -2,6 +2,7 @@
 
 test_description='git p4 fetching changes in multiple blocks'
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./lib-git-p4.sh
 
 test_expect_success 'start p4d' '
index b4d93f0c17c35722184d09d354556e59fef8a2b4..985be2035716207a38cae6c632de647b29606c24 100755 (executable)
@@ -2,6 +2,7 @@
 
 test_description='interaction with P4 case-folding'
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./lib-git-p4.sh
 
 if test_have_prereq CASE_INSENSITIVE_FS
index fa1bba1dd93614c8ad5c7f4a37c5b612440fd0eb..48e4dfb95c03c3cc5a1592944cc1c4d03d056118 100755 (executable)
@@ -2,6 +2,7 @@
 
 test_description='git p4 handling of EDITOR'
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./lib-git-p4.sh
 
 test_expect_success 'start p4d' '
index ef80f1690bcb9ad153df900e277ef48ce8e4e62e..49691c53dadddb85c7dbaf0e0a52336d2b91d349 100755 (executable)
@@ -2,6 +2,7 @@
 
 test_description='Clone repositories with path case variations'
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./lib-git-p4.sh
 
 test_expect_success 'start p4d with case folding enabled' '
index 572d395498e30a3743b77c577d7c4b91d714b392..e62ed49f51e02263c4a1c5615f6fe825939f8a6c 100755 (executable)
@@ -2,6 +2,7 @@
 
 test_description='Clone repositories with non ASCII paths'
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./lib-git-p4.sh
 
 UTF8_ESCAPED="a-\303\244_o-\303\266_u-\303\274.txt"
index 88b76dc4d6c26fc99e32c91a11b2eb5bb7118e2c..98a40d8af3793b61df8718c832f7f19705bf6f67 100755 (executable)
@@ -2,6 +2,7 @@
 
 test_description='Clone repositories and store files in Mock LFS'
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./lib-git-p4.sh
 
 test_file_is_not_in_mock_lfs () {
index 6a60b32349391304ad4bb3ef85122e27885ccf4d..d0b86537dd975a5c905a318e1df1a4672ed68e73 100755 (executable)
@@ -2,6 +2,7 @@
 
 test_description='git p4 handling of UTF-16 files without BOM'
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./lib-git-p4.sh
 
 UTF16="\227\000\227\000"
index fd64afe064e5a937b4a15d18f70e87cd524067c8..54083f842e9259ca21f0e6e5f1fe8a20bb74092e 100755 (executable)
@@ -2,6 +2,7 @@
 
 test_description='Clone repositories and keep empty commits'
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./lib-git-p4.sh
 
 test_expect_success 'start p4d' '
index d3670bd7a24dbf3cdc350939d6d130bd662f3e73..3476ea2fd3b5773421f989b974e5eb88663a7845 100755 (executable)
@@ -2,6 +2,7 @@
 
 test_description='git p4 support for file type change'
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./lib-git-p4.sh
 
 test_expect_success 'start p4d' '
index ca6c2942bdf200942cc4122e6172a120e0f1d1c1..7c8f9e3930406de82e80817a25a0bd9eb9324fbf 100755 (executable)
@@ -2,6 +2,7 @@
 
 test_description='Clone repositories and map users'
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./lib-git-p4.sh
 
 test_expect_success 'start p4d' '
index 88cfb1fcd3f0a1401fd1cdb10f1fe697a5c4aaa3..3fc0948d9cff2060381eab9bb8178419d656a157 100755 (executable)
@@ -2,6 +2,7 @@
 
 test_description='git p4 retrieve job info'
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./lib-git-p4.sh
 
 test_expect_success 'start p4d' '
index 3fb6960c18fc0c2eb549f09c66d92b3f39822653..02561a7f0e62f7919ac897d733c4edd3c7e9b695 100755 (executable)
@@ -2,6 +2,7 @@
 
 test_description='git p4 symlinked directories'
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./lib-git-p4.sh
 
 test_expect_success 'start p4d' '
index ff6c0352e688246e9b97e063679889c2583c459e..f287f41e3741e10b2576a9d554a8be20d1778fe2 100755 (executable)
@@ -2,6 +2,7 @@
 
 test_description='git p4 with server triggers'
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./lib-git-p4.sh
 
 test_expect_success 'start p4d' '
index 6b3cb0414aa08cb62817ba9f0710e6db4d282787..a2667754086a5c64addc6c079fd017d313809883 100755 (executable)
@@ -6,6 +6,7 @@ last_shelved_change () {
 
 test_description='git p4 unshelve'
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./lib-git-p4.sh
 
 test_expect_success 'start p4d' '
index e22369ccdf5f15840546269d0cdef9e8a54ce698..da1d30c142c4fae651953537ef11512b387e9851 100755 (executable)
@@ -2,6 +2,7 @@
 
 test_description='git p4 errors'
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./lib-git-p4.sh
 
 test_expect_success 'start p4d' '
index dac67e89d7d720a916eec8a533d9b1f05101525a..565870fc740cb228d9b614920e13a53da118641d 100755 (executable)
@@ -6,6 +6,7 @@ This test creates files and directories with the same name in perforce and
 checks that git-p4 recovers from the error at the same time as the perforce
 repository.'
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./lib-git-p4.sh
 
 test_expect_success 'start p4d' '
index 036bf79c6674f6f1f0d667c7270674168428ffee..ad20ffdededdc9bc3099818a7ad5747b0470c864 100755 (executable)
@@ -6,6 +6,7 @@ This test checks that the import process handles inconsistent text
 encoding in p4 metadata (author names, commit messages, etc) without
 failing, and produces maximally sane output in git.'
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./lib-git-p4.sh
 
 python_target_version='2'
index 63350dc4b5c6262480cd0be8fd88fba714c55428..71ae763399c084129b3c17b00eb73cbee233b1f8 100755 (executable)
@@ -6,6 +6,7 @@ This test checks that the import process handles inconsistent text
 encoding in p4 metadata (author names, commit messages, etc) without
 failing, and produces maximally sane output in git.'
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./lib-git-p4.sh
 
 python_target_version='3'