]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/i915: Add missing else to the if ladder in missing else
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Mon, 17 Feb 2025 07:00:40 +0000 (09:00 +0200)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Mon, 17 Feb 2025 23:24:57 +0000 (01:24 +0200)
The if ladder in gen8_de_pipe_fault_mask() was missing one
else, add it. Doesn't actually matter since each if branch
just returns directly. But the code is less confusing when
you always do things the same way.

Reviewed-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20250217070047.953-2-ville.syrjala@linux.intel.com
drivers/gpu/drm/i915/display/intel_display_irq.c

index 880eaed83cd5a2bf87c5a3274109c86554e7a3b7..d3ba8e2cf5a13a72d5c95b63e84d4bcadbb2eaa7 100644 (file)
@@ -908,7 +908,7 @@ static u32 gen8_de_pipe_fault_mask(struct drm_i915_private *dev_priv)
                        GEN9_PIPE_PLANE3_FAULT |
                        GEN9_PIPE_PLANE2_FAULT |
                        GEN9_PIPE_PLANE1_FAULT;
-       if (DISPLAY_VER(display) >= 13 || HAS_D12_PLANE_MINIMIZATION(display))
+       else if (DISPLAY_VER(display) >= 13 || HAS_D12_PLANE_MINIMIZATION(display))
                return GEN12_PIPEDMC_FAULT |
                        GEN9_PIPE_CURSOR_FAULT |
                        GEN11_PIPE_PLANE5_FAULT |