]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
scsi: snic: Simplify alloc_workqueue() invocations
authorBart Van Assche <bvanassche@acm.org>
Thu, 22 Aug 2024 19:59:18 +0000 (12:59 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 23 Aug 2024 01:28:56 +0000 (21:28 -0400)
Let alloc_workqueue() format the workqueue name instead of calling
snprintf() explicitly. Not setting shost->work_q_name is safe because
there is no code that reads the value set by the removed code.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20240822195944.654691-15-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/snic/snic_main.c

index 2bd01eb57869e30bc6364303f9d5ec2dedc1de8d..5ca8bc89dfa79fb081f8027a97168e084b990384 100644 (file)
@@ -300,10 +300,8 @@ snic_add_host(struct Scsi_Host *shost, struct pci_dev *pdev)
        }
 
        SNIC_BUG_ON(shost->work_q != NULL);
-       snprintf(shost->work_q_name, sizeof(shost->work_q_name), "scsi_wq_%d",
-                shost->host_no);
-       shost->work_q = alloc_ordered_workqueue("%s", WQ_MEM_RECLAIM,
-                                               shost->work_q_name);
+       shost->work_q = alloc_ordered_workqueue("scsi_wq_%d", WQ_MEM_RECLAIM,
+                                               shost->host_no);
        if (!shost->work_q) {
                SNIC_HOST_ERR(shost, "Failed to Create ScsiHost wq.\n");