]> git.ipfire.org Git - thirdparty/kernel/stable-queue.git/commitdiff
4.19-stable patches
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 18 Feb 2023 11:19:39 +0000 (12:19 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 18 Feb 2023 11:19:39 +0000 (12:19 +0100)
added patches:
i40e-add-double-of-vlan-header-when-computing-the-max-mtu.patch
net-bgmac-fix-bcm5358-support-by-setting-correct-flags.patch
revert-squashfs-harden-sanity-check-in-squashfs_read_xattr_id_table.patch

queue-4.19/i40e-add-double-of-vlan-header-when-computing-the-max-mtu.patch [new file with mode: 0644]
queue-4.19/net-bgmac-fix-bcm5358-support-by-setting-correct-flags.patch [new file with mode: 0644]
queue-4.19/revert-squashfs-harden-sanity-check-in-squashfs_read_xattr_id_table.patch [new file with mode: 0644]
queue-4.19/series

diff --git a/queue-4.19/i40e-add-double-of-vlan-header-when-computing-the-max-mtu.patch b/queue-4.19/i40e-add-double-of-vlan-header-when-computing-the-max-mtu.patch
new file mode 100644 (file)
index 0000000..9749185
--- /dev/null
@@ -0,0 +1,33 @@
+From ce45ffb815e8e238f05de1630be3969b6bb15e4e Mon Sep 17 00:00:00 2001
+From: Jason Xing <kernelxing@tencent.com>
+Date: Wed, 8 Feb 2023 10:43:33 +0800
+Subject: i40e: add double of VLAN header when computing the max MTU
+
+From: Jason Xing <kernelxing@tencent.com>
+
+commit ce45ffb815e8e238f05de1630be3969b6bb15e4e upstream.
+
+Include the second VLAN HLEN into account when computing the maximum
+MTU size as other drivers do.
+
+Fixes: 0c8493d90b6b ("i40e: add XDP support for pass and drop actions")
+Signed-off-by: Jason Xing <kernelxing@tencent.com>
+Reviewed-by: Alexander Duyck <alexanderduyck@fb.com>
+Tested-by: Chandan Kumar Rout <chandanx.rout@intel.com> (A Contingent Worker at Intel)
+Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ drivers/net/ethernet/intel/i40e/i40e_main.c |    2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+--- a/drivers/net/ethernet/intel/i40e/i40e_main.c
++++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
+@@ -2671,7 +2671,7 @@ static int i40e_change_mtu(struct net_de
+       struct i40e_pf *pf = vsi->back;
+       if (i40e_enabled_xdp_vsi(vsi)) {
+-              int frame_size = new_mtu + ETH_HLEN + ETH_FCS_LEN + VLAN_HLEN;
++              int frame_size = new_mtu + I40E_PACKET_HDR_PAD;
+               if (frame_size > i40e_max_xdp_frame_size(vsi))
+                       return -EINVAL;
diff --git a/queue-4.19/net-bgmac-fix-bcm5358-support-by-setting-correct-flags.patch b/queue-4.19/net-bgmac-fix-bcm5358-support-by-setting-correct-flags.patch
new file mode 100644 (file)
index 0000000..a45b73a
--- /dev/null
@@ -0,0 +1,51 @@
+From d61615c366a489646a1bfe5b33455f916762d5f4 Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= <rafal@milecki.pl>
+Date: Wed, 8 Feb 2023 10:16:37 +0100
+Subject: net: bgmac: fix BCM5358 support by setting correct flags
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+From: Rafał Miłecki <rafal@milecki.pl>
+
+commit d61615c366a489646a1bfe5b33455f916762d5f4 upstream.
+
+Code blocks handling BCMA_CHIP_ID_BCM5357 and BCMA_CHIP_ID_BCM53572 were
+incorrectly unified. Chip package values are not unique and cannot be
+checked independently. They are meaningful only in a context of a given
+chip.
+
+Packages BCM5358 and BCM47188 share the same value but then belong to
+different chips. Code unification resulted in treating BCM5358 as
+BCM47188 and broke its initialization.
+
+Link: https://github.com/openwrt/openwrt/issues/8278
+Fixes: cb1b0f90acfe ("net: ethernet: bgmac: unify code of the same family")
+Cc: Jon Mason <jdmason@kudzu.us>
+Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
+Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
+Link: https://lore.kernel.org/r/20230208091637.16291-1-zajec5@gmail.com
+Signed-off-by: Jakub Kicinski <kuba@kernel.org>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ drivers/net/ethernet/broadcom/bgmac-bcma.c |    6 +++---
+ 1 file changed, 3 insertions(+), 3 deletions(-)
+
+--- a/drivers/net/ethernet/broadcom/bgmac-bcma.c
++++ b/drivers/net/ethernet/broadcom/bgmac-bcma.c
+@@ -228,12 +228,12 @@ static int bgmac_probe(struct bcma_devic
+               bgmac->feature_flags |= BGMAC_FEAT_CLKCTLST;
+               bgmac->feature_flags |= BGMAC_FEAT_FLW_CTRL1;
+               bgmac->feature_flags |= BGMAC_FEAT_SW_TYPE_PHY;
+-              if (ci->pkg == BCMA_PKG_ID_BCM47188 ||
+-                  ci->pkg == BCMA_PKG_ID_BCM47186) {
++              if ((ci->id == BCMA_CHIP_ID_BCM5357 && ci->pkg == BCMA_PKG_ID_BCM47186) ||
++                  (ci->id == BCMA_CHIP_ID_BCM53572 && ci->pkg == BCMA_PKG_ID_BCM47188)) {
+                       bgmac->feature_flags |= BGMAC_FEAT_SW_TYPE_RGMII;
+                       bgmac->feature_flags |= BGMAC_FEAT_IOST_ATTACHED;
+               }
+-              if (ci->pkg == BCMA_PKG_ID_BCM5358)
++              if (ci->id == BCMA_CHIP_ID_BCM5357 && ci->pkg == BCMA_PKG_ID_BCM5358)
+                       bgmac->feature_flags |= BGMAC_FEAT_SW_TYPE_EPHYRMII;
+               break;
+       case BCMA_CHIP_ID_BCM53573:
diff --git a/queue-4.19/revert-squashfs-harden-sanity-check-in-squashfs_read_xattr_id_table.patch b/queue-4.19/revert-squashfs-harden-sanity-check-in-squashfs_read_xattr_id_table.patch
new file mode 100644 (file)
index 0000000..9664ad5
--- /dev/null
@@ -0,0 +1,34 @@
+From a5b21d8d791cd4db609d0bbcaa9e0c7e019888d1 Mon Sep 17 00:00:00 2001
+From: Andrew Morton <akpm@linux-foundation.org>
+Date: Thu, 2 Feb 2023 18:07:35 -0800
+Subject: revert "squashfs: harden sanity check in squashfs_read_xattr_id_table"
+
+From: Andrew Morton <akpm@linux-foundation.org>
+
+commit a5b21d8d791cd4db609d0bbcaa9e0c7e019888d1 upstream.
+
+This fix was nacked by Philip, for reasons identified in the email linked
+below.
+
+Link: https://lkml.kernel.org/r/68f15d67-8945-2728-1f17-5b53a80ec52d@squashfs.org.uk
+Fixes: 72e544b1b28325 ("squashfs: harden sanity check in squashfs_read_xattr_id_table")
+Cc: Alexey Khoroshilov <khoroshilov@ispras.ru>
+Cc: Fedor Pchelkin <pchelkin@ispras.ru>
+Cc: Phillip Lougher <phillip@squashfs.org.uk>
+Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ fs/squashfs/xattr_id.c |    2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+--- a/fs/squashfs/xattr_id.c
++++ b/fs/squashfs/xattr_id.c
+@@ -89,7 +89,7 @@ __le64 *squashfs_read_xattr_id_table(str
+       /* Sanity check values */
+       /* there is always at least one xattr id */
+-      if (*xattr_ids <= 0)
++      if (*xattr_ids == 0)
+               return ERR_PTR(-EINVAL);
+       len = SQUASHFS_XATTR_BLOCK_BYTES(*xattr_ids);
index aff5837cd937076abd6fd956a026974c4e446f9e..f51a40179102d994cf9877b29d96e8da1ca0d330 100644 (file)
@@ -73,3 +73,6 @@ mmc-sdio-fix-possible-resource-leaks-in-some-error-paths.patch
 alsa-hda-conexant-add-a-new-hda-codec-sn6180.patch
 alsa-hda-realtek-fixed-wrong-gpio-assigned.patch
 hugetlb-check-for-undefined-shift-on-32-bit-architectures.patch
+revert-squashfs-harden-sanity-check-in-squashfs_read_xattr_id_table.patch
+i40e-add-double-of-vlan-header-when-computing-the-max-mtu.patch
+net-bgmac-fix-bcm5358-support-by-setting-correct-flags.patch