KVM: x86: Apply Intel's TSC_AUX reserved-bit behavior to Intel compat vCPUs

Extend Intel's check on MSR_TSC_AUX[63:32] to all vCPU models that are
Intel compatible, i.e. aren't AMD or Hygon in KVM's world, as the behavior
is architectural, i.e. applies to any CPU that is compatible with Intel's
architecture.  Applying the behavior strictly to Intel wasn't intentional,
KVM simply didn't have a concept of "Intel compatible" as of commit
61a05d444d2c ("KVM: x86: Tie Intel and AMD behavior for MSR_TSC_AUX to
guest CPU model").

Link: https://lore.kernel.org/r/20240405235603.1173076-5-seanjc@google.com
Signed-off-by: Sean Christopherson <seanjc@google.com>

diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index e60c13da89946b72f32f9cfa7ae2371c2f2cf06b..f28413fc3adc31f594c8be255ff3a88f2343776c 100644 (file)
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -1878,11 +1878,11 @@ static int __kvm_set_msr(struct kvm_vcpu *vcpu, u32 index, u64 data,
                 * incomplete and conflicting architectural behavior.  Current
                 * AMD CPUs completely ignore bits 63:32, i.e. they aren't
                 * reserved and always read as zeros.  Enforce Intel's reserved
-                * bits check if and only if the guest CPU is Intel, and clear
-                * the bits in all other cases.  This ensures cross-vendor
-                * migration will provide consistent behavior for the guest.
+                * bits check if the guest CPU is Intel compatible, otherwise
+                * clear the bits.  This ensures cross-vendor migration will
+                * provide consistent behavior for the guest.
                 */
-               if (guest_cpuid_is_intel(vcpu) && (data >> 32) != 0)
+               if (guest_cpuid_is_intel_compatible(vcpu) && (data >> 32) != 0)
                        return 1;
 
                data = (u32)data;