]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
PCI: vmd: Silence 'set affinity failed' warning
authorMarek Vasut <marek.vasut+renesas@mailbox.org>
Tue, 23 Jul 2024 13:27:12 +0000 (15:27 +0200)
committerBjorn Helgaas <bhelgaas@google.com>
Tue, 6 Aug 2024 17:52:03 +0000 (12:52 -0500)
Use MSI_FLAG_NO_AFFINITY, which keeps .irq_set_affinity() unset and allows
migrate_one_irq() to exit right away, without warnings like this:

  IRQ...: set affinity failed(-22)

Remove the .irq_set_affinity() implementation that is no longer needed.

Link: https://lore.kernel.org/r/20240723132958.41320-13-marek.vasut+renesas@mailbox.org
Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
[bhelgaas: commit log]
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Reviewed-by: Nirmal Patel <nirmal.patel@linux.intel.com>
Acked-by: Thomas Gleixner <tglx@linutronix.de>
drivers/pci/controller/vmd.c

index a726de0af011f973fb4d18f3d6cc9302cbd1509d..bc849b0d9e8dc09756087b374d1c364bdc237ee9 100644 (file)
@@ -204,22 +204,11 @@ static void vmd_irq_disable(struct irq_data *data)
        raw_spin_unlock_irqrestore(&list_lock, flags);
 }
 
-/*
- * XXX: Stubbed until we develop acceptable way to not create conflicts with
- * other devices sharing the same vector.
- */
-static int vmd_irq_set_affinity(struct irq_data *data,
-                               const struct cpumask *dest, bool force)
-{
-       return -EINVAL;
-}
-
 static struct irq_chip vmd_msi_controller = {
        .name                   = "VMD-MSI",
        .irq_enable             = vmd_irq_enable,
        .irq_disable            = vmd_irq_disable,
        .irq_compose_msi_msg    = vmd_compose_msi_msg,
-       .irq_set_affinity       = vmd_irq_set_affinity,
 };
 
 static irq_hw_number_t vmd_get_hwirq(struct msi_domain_info *info,
@@ -326,7 +315,7 @@ static struct msi_domain_ops vmd_msi_domain_ops = {
 
 static struct msi_domain_info vmd_msi_domain_info = {
        .flags          = MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS |
-                         MSI_FLAG_PCI_MSIX,
+                         MSI_FLAG_NO_AFFINITY | MSI_FLAG_PCI_MSIX,
        .ops            = &vmd_msi_domain_ops,
        .chip           = &vmd_msi_controller,
 };