]> git.ipfire.org Git - thirdparty/git.git/commitdiff
http: drop unused parameter from start_object_request()
authorJeff King <peff@peff.net>
Fri, 17 Mar 2023 19:16:34 +0000 (15:16 -0400)
committerJunio C Hamano <gitster@pobox.com>
Fri, 17 Mar 2023 21:17:48 +0000 (14:17 -0700)
We take a "walker" parameter for the request, but don't actually look at
it. This is due to 5424bc557f (http*: add helper methods for fetching
objects (loose), 2009-06-06). Before then, we consulted the "walker"
struct to tell us if we should be verbose, but now those messages are
printed elsewhere.

Let's drop the unused parameter to make -Wunused-parameter happy.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
http-walker.c

index c3e902c40e654d86b8e2cefe2d8ccd6a475d3e5e..065a03d262bb751e4677f031738fc39abcff4cfa 100644 (file)
@@ -53,8 +53,7 @@ static void fetch_alternates(struct walker *walker, const char *base);
 
 static void process_object_response(void *callback_data);
 
-static void start_object_request(struct walker *walker,
-                                struct object_request *obj_req)
+static void start_object_request(struct object_request *obj_req)
 {
        struct active_request_slot *slot;
        struct http_object_request *req;
@@ -111,7 +110,7 @@ static void process_object_response(void *callback_data)
                        obj_req->repo =
                                obj_req->repo->next;
                        release_http_object_request(obj_req->req);
-                       start_object_request(walker, obj_req);
+                       start_object_request(obj_req);
                        return;
                }
        }
@@ -139,7 +138,7 @@ static int fill_active_slot(struct walker *walker)
                        if (has_object_file(&obj_req->oid))
                                obj_req->state = COMPLETE;
                        else {
-                               start_object_request(walker, obj_req);
+                               start_object_request(obj_req);
                                return 1;
                        }
                }