phy: stm32: ensure phy are no more active when removing the driver

To ensure a good balancing of regulators, and allow PLL disabling when the
driver is removed, call stm32_usbphyc_phy_exit on each ports to set phys
inactive and disable PLL.

Signed-off-by: Amelie Delaunay <amelie.delaunay@foss.st.com>
Link: https://lore.kernel.org/r/20210105090525.23164-6-amelie.delaunay@foss.st.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>

diff --git a/drivers/phy/st/phy-stm32-usbphyc.c b/drivers/phy/st/phy-stm32-usbphyc.c
index 33367a325612c9c49d0f54827b75e9cf86a3860f..8b11d95b2c207f33cab819e65452a64ca839afcb 100644 (file)
--- a/drivers/phy/st/phy-stm32-usbphyc.c
+++ b/drivers/phy/st/phy-stm32-usbphyc.c
@@ -470,6 +470,12 @@ clk_disable:
 static int stm32_usbphyc_remove(struct platform_device *pdev)
 {
        struct stm32_usbphyc *usbphyc = dev_get_drvdata(&pdev->dev);
+       int port;
+
+       /* Ensure PHYs are not active, to allow PLL disabling */
+       for (port = 0; port < usbphyc->nphys; port++)
+               if (usbphyc->phys[port]->active)
+                       stm32_usbphyc_phy_exit(usbphyc->phys[port]->phy);
 
        clk_disable_unprepare(usbphyc->clk);