]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
i3c: Remove superfluous FIXME
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Tue, 23 Sep 2025 20:35:58 +0000 (22:35 +0200)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Tue, 23 Sep 2025 22:46:15 +0000 (00:46 +0200)
I2C adapters can already change timeout and retry parameters via IOCTL.
This allows for better tuning to workloads compared to per-adapter
defaults. So, the FIXME is not needed.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Link: https://lore.kernel.org/r/20250923203557.18298-2-wsa+renesas@sang-engineering.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/i3c/master.c

index acaba4d5369712460cff14941935858ab3697546..d946db75df706812254e4e40b7f3c4482d2f8e77 100644 (file)
@@ -2564,8 +2564,6 @@ static int i3c_master_i2c_adapter_init(struct i3c_master_controller *master)
        adap->owner = master->dev.parent->driver->owner;
        adap->algo = &i3c_master_i2c_algo;
        strscpy(adap->name, dev_name(master->dev.parent), sizeof(adap->name));
-
-       /* FIXME: Should we allow i3c masters to override these values? */
        adap->timeout = HZ;
        adap->retries = 3;