leds: cr0014114: Switch to device_for_each_child_node_scoped()

Switch to device_for_each_child_node_scoped() to simplify the code by
removing the need for calls to fwnode_handle_put() in the error paths.

This also prevents possible memory leaks if new error paths are added
without the required call to fwnode_handle_put().

Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Link: https://lore.kernel.org/r/20240927-leds_device_for_each_child_node_scoped-v1-5-95c0614b38c8@gmail.com
Signed-off-by: Lee Jones <lee@kernel.org>

diff --git a/drivers/leds/leds-cr0014114.c b/drivers/leds/leds-cr0014114.c
index c9914fc51f202331e673d2fda97c243ee7467e5a..7e51c374edd4e2a0070c6aa22a31c1b446c31a74 100644 (file)
--- a/drivers/leds/leds-cr0014114.c
+++ b/drivers/leds/leds-cr0014114.c
@@ -181,11 +181,10 @@ static int cr0014114_probe_dt(struct cr0014114 *priv)
 {
        size_t                  i = 0;
        struct cr0014114_led    *led;
-       struct fwnode_handle    *child;
        struct led_init_data    init_data = {};
        int                     ret;
 
-       device_for_each_child_node(priv->dev, child) {
+       device_for_each_child_node_scoped(priv->dev, child) {
                led = &priv->leds[i];
 
                led->priv                         = priv;
@@ -201,7 +200,6 @@ static int cr0014114_probe_dt(struct cr0014114 *priv)
                if (ret) {
                        dev_err(priv->dev,
                                "failed to register LED device, err %d", ret);
-                       fwnode_handle_put(child);
                        return ret;
                }