]> git.ipfire.org Git - thirdparty/unbound.git/commitdiff
- Fix #1270: unitauth.c doesn't compile with higher warning level
authorWouter Wijngaards <wouter@nlnetlabs.nl>
Fri, 26 May 2017 06:50:48 +0000 (06:50 +0000)
committerWouter Wijngaards <wouter@nlnetlabs.nl>
Fri, 26 May 2017 06:50:48 +0000 (06:50 +0000)
  and optimization

git-svn-id: file:///svn/unbound/trunk@4191 be551aaa-1e26-0410-a405-d3ace91eadb9

doc/Changelog
testcode/unitauth.c

index 19983ac5de926d56666c42d5d4a4e97fa03f02a9..24f874dbba69b60a29a1317067728587e502a98d 100644 (file)
@@ -1,3 +1,7 @@
+26 May 2017: Wouter
+       - Fix #1270: unitauth.c doesn't compile with higher warning level
+         and optimization
+
 24 May 2017: Wouter
        - authzone cname chain, no rrset duplicates, wildcard doesn't change
          rrsets added for cname chain.
index 0aa1fa04ca8e144f2dede1abaa276f78aeebe94b..f6c022aa03d702fc178b71920cefc7b4e85c393a 100644 (file)
@@ -543,9 +543,12 @@ checkfile(char* f1, char *f2)
        if(!i2) fatal_exit("cannot open %s: %s", f2, strerror(errno));
 
        while(!feof(i1) && !feof(i2)) {
+               char* cp1, *cp2;
                line++;
-               (void)fgets(buf1, (int)sizeof(buf1), i1);
-               (void)fgets(buf2, (int)sizeof(buf2), i2);
+               cp1 = fgets(buf1, (int)sizeof(buf1), i1);
+               cp2 = fgets(buf2, (int)sizeof(buf2), i2);
+               if((!cp1 && !feof(i1)) || (!cp2 && !feof(i2)))
+                       fatal_exit("fgets failed: %s", strerror(errno));
                if(strcmp(buf1, buf2) != 0) {
                        log_info("in files %s and %s:%d", f1, f2, line);
                        log_info("'%s'", buf1);