reindexdb: Skip reindexing temporary tables and indexes.

Reindexing temp tables or indexes of other sessions is not allowed.
However, reindexdb in parallel mode previously listed them as
the objects to process, leading to failures.

This commit ensures reindexdb in parallel mode skips temporary tables
and indexes by adding a condition based on the relpersistence column
in pg_class to the object listing queries, preventing these issues.

Note that this commit does not affect reindexdb when temporary tables
or indexes are explicitly specified using the -t or -j options;
reindexdb in that case still does not skip them and can cause an error.

Back-patch to v13 where parallel mode was introduced in reindexdb.

Author: Fujii Masao
Reviewed-by: Michael Paquier
Discussion: https://postgr.es/m/5f37ee56-14fb-44fe-9150-9eb97e10538b@oss.nttdata.com

diff --git a/src/bin/scripts/reindexdb.c b/src/bin/scripts/reindexdb.c
index 5b297d1dc163d727a8331c6573af4371664df9c3..b3becff8eca62234e80784613ccbe9114cc5bdca 100644 (file)
--- a/src/bin/scripts/reindexdb.c
+++ b/src/bin/scripts/reindexdb.c
@@ -626,6 +626,8 @@ get_parallel_object_list(PGconn *conn, ReindexType type,
                                                                 "   AND c.relkind IN ("
                                                                 CppAsString2(RELKIND_RELATION) ", "
                                                                 CppAsString2(RELKIND_MATVIEW) ")\n"
+                                                                "   AND c.relpersistence != "
+                                                                CppAsString2(RELPERSISTENCE_TEMP) "\n"
                                                                 " ORDER BY c.relpages DESC;");
                        break;
 
@@ -648,6 +650,8 @@ get_parallel_object_list(PGconn *conn, ReindexType type,
                                                                         " WHERE c.relkind IN ("
                                                                         CppAsString2(RELKIND_RELATION) ", "
                                                                         CppAsString2(RELKIND_MATVIEW) ")\n"
+                                                                        "   AND c.relpersistence != "
+                                                                        CppAsString2(RELPERSISTENCE_TEMP) "\n"
                                                                         " AND ns.nspname IN (");
 
                                for (cell = user_list->head; cell; cell = cell->next)