Bug 3140: memory leak in error page generation

Avoid freeing buffer m before using it. Specific to the 3.2+ logics.

diff --git a/src/errorpage.cc b/src/errorpage.cc
index d4f7ee7bc922162d502aba46c478f1c5417cc50a..fc92e04565c8e9f58f0471afb794f5dbb141eda3 100644 (file)
--- a/src/errorpage.cc
+++ b/src/errorpage.cc
@@ -1168,11 +1168,12 @@ ErrorState::BuildContent()
         debugs(4, 2, HERE << "No existing error page language negotiated for " << errorPageName(page_id) << ". Using default error file.");
     }
 
+    MemBuf *result = ConvertText(m, true);
 #if USE_ERR_LOCALES
     safe_free(freePage);
 #endif
 
-    return ConvertText(m, true);
+    return result;
 }
 
 MemBuf *ErrorState::ConvertText(const char *text, bool allowRecursion)