cobol: Fix incorrect use of std::remove_if

The call to std::remove_if used here doesn't remove any elements, it
just overwrites the "removed" elements with later elements, leaving the
total number of elements unchanged. Use std::list::remove_if to actually
remove those unwanted elements from the list.

gcc/cobol/ChangeLog:

	* symfind.cc (finalize_symbol_map2): Use std::list::remove_if
	instead of std::remove_if.

diff --git a/gcc/cobol/symfind.cc b/gcc/cobol/symfind.cc
index 2687fdb83df2f82f651c543d1750819bffd50967..899571551e8fd1bf70aa72df589e4aae83562dd6 100644 (file)
--- a/gcc/cobol/symfind.cc
+++ b/gcc/cobol/symfind.cc
@@ -128,11 +128,10 @@ finalize_symbol_map2() {
 
   for( auto& elem : symbol_map2 ) {
     auto& fields( elem.second );
-    std::remove_if( fields.begin(), fields.end(),
-                  []( auto isym ) {
-                    auto f = cbl_field_of(symbol_at(isym));
-                    return f->type == FldInvalid;
-                  } );
+    fields.remove_if( []( auto isym ) {
+                       auto f = cbl_field_of(symbol_at(isym));
+                       return f->type == FldInvalid;
+                     } );
     if( fields.empty() ) empties.insert(elem.first);
   }