]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
x86/acpi: Rename fields in the acpi_madt_multiproc_wakeup structure
authorKirill A. Shutemov <kirill.shutemov@linux.intel.com>
Fri, 14 Jun 2024 09:58:59 +0000 (12:58 +0300)
committerBorislav Petkov (AMD) <bp@alien8.de>
Mon, 17 Jun 2024 15:46:15 +0000 (17:46 +0200)
In order to support MADT wakeup structure version 1, provide more appropriate
names for the fields in the structure.

Rename 'mailbox_version' to 'version'. This field signifies the version of the
structure and the related protocols, rather than the version of the mailbox.
This field has not been utilized in the code thus far.

Rename 'base_address' to 'mailbox_address' to clarify the kind of address it
represents. In version 1, the structure includes the reset vector address. Clear
and distinct naming helps to prevent any confusion.

Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Reviewed-by: Kai Huang <kai.huang@intel.com>
Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Tested-by: Tao Liu <ltao@redhat.com>
Link: https://lore.kernel.org/r/20240614095904.1345461-15-kirill.shutemov@linux.intel.com
arch/x86/kernel/acpi/madt_wakeup.c
include/acpi/actbl2.h

index d222be8d7a07155e1191f4ab33486ff612d56c10..004801b9b151516dd6094183863a5fb5e6bd77a5 100644 (file)
@@ -75,7 +75,7 @@ int __init acpi_parse_mp_wake(union acpi_subtable_headers *header,
 
        acpi_table_print_madt_entry(&header->common);
 
-       acpi_mp_wake_mailbox_paddr = mp_wake->base_address;
+       acpi_mp_wake_mailbox_paddr = mp_wake->mailbox_address;
 
        cpu_hotplug_disable_offlining();
 
index ae747c89d92c61bbcee2b3e98c6144712bcb51d7..fa63362469aaafe9ef5d97be5531ad7c2ac410b5 100644 (file)
@@ -1194,9 +1194,9 @@ struct acpi_madt_generic_translator {
 
 struct acpi_madt_multiproc_wakeup {
        struct acpi_subtable_header header;
-       u16 mailbox_version;
+       u16 version;
        u32 reserved;           /* reserved - must be zero */
-       u64 base_address;
+       u64 mailbox_address;
 };
 
 #define ACPI_MULTIPROC_WAKEUP_MB_OS_SIZE        2032