]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
scsi: ufs: qcom: Check gear against max gear in vop freq_to_gear()
authorZiqi Chen <quic_ziqichen@quicinc.com>
Thu, 22 May 2025 02:15:35 +0000 (10:15 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 28 May 2025 02:06:40 +0000 (22:06 -0400)
The vop freq_to_gear() may return a gear greater than the negotiated max
gear. Return the negotiated max gear if the mapped gear is greater.

Fixes: c02fe9e222d1 ("scsi: ufs: qcom: Implement the freq_to_gear_speed() vop")
Signed-off-by: Ziqi Chen <quic_ziqichen@quicinc.com>
Link: https://lore.kernel.org/r/20250522021537.999107-2-quic_ziqichen@quicinc.com
Reported-by: Neil Armstrong <neil.armstrong@linaro.org>
Closes: https://lore.kernel.org/all/c7f2476a-943a-4d73-ad80-802c91e5f880@linaro.org/
Tested-by: Neil Armstrong <neil.armstrong@linaro.org>
Reviewed-by: Bean Huo <beanhuo@micron.com>
Tested-by: Loïc Minier <loic.minier@oss.qualcomm.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/ufs/host/ufs-qcom.c

index 790da25cbaf317e782539f7d56574f758f67d470..654d970b6dec6826051ddaa8a9395673c54db91e 100644 (file)
@@ -2083,7 +2083,7 @@ static int ufs_qcom_config_esi(struct ufs_hba *hba)
 
 static u32 ufs_qcom_freq_to_gear_speed(struct ufs_hba *hba, unsigned long freq)
 {
-       u32 gear = 0;
+       u32 gear = UFS_HS_DONT_CHANGE;
 
        switch (freq) {
        case 403000000:
@@ -2105,10 +2105,10 @@ static u32 ufs_qcom_freq_to_gear_speed(struct ufs_hba *hba, unsigned long freq)
                break;
        default:
                dev_err(hba->dev, "%s: Unsupported clock freq : %lu\n", __func__, freq);
-               break;
+               return UFS_HS_DONT_CHANGE;
        }
 
-       return gear;
+       return min_t(u32, gear, hba->max_pwr_info.info.gear_rx);
 }
 
 /*