perf/core: Fix perf_mmap() failure path

When f_ops->mmap() returns failure, m_ops->close() is *not* called.

Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Acked-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Reviewed-by: Ravi Bangoria <ravi.bangoria@amd.com>
Link: https://lore.kernel.org/r/20241104135519.248358497@infradead.org

diff --git a/kernel/events/core.c b/kernel/events/core.c
index 8b2a8c36d1241b14f2f5f5de5250e21b22eb1fd9..b2334d27511b6cf293dfa69de4bc762c6ea7e38f 100644 (file)
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -6903,7 +6903,7 @@ aux_unlock:
        if (!ret)
                ret = map_range(rb, vma);
 
-       if (event->pmu->event_mapped)
+       if (!ret && event->pmu->event_mapped)
                event->pmu->event_mapped(event, vma->vm_mm);
 
        return ret;