]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
mm/damon/core: remove duplicate list_empty quota->goals check
authorHonggyu Kim <honggyu.kim@sk.com>
Tue, 14 Jan 2025 06:40:34 +0000 (22:40 -0800)
committerAndrew Morton <akpm@linux-foundation.org>
Tue, 14 Jan 2025 06:40:34 +0000 (22:40 -0800)
damos_set_effective_quota() checks quota contidions but there are some
duplicate checks for quota->goals inside.

This patch reduces one of if statement to simplify the esz calculation
logic by setting esz as ULONG_MAX by default.

Link: https://lkml.kernel.org/r/20241125184307.41746-1-sj@kernel.org
Signed-off-by: Honggyu Kim <honggyu.kim@sk.com>
Reviewed-by: SeongJae Park <sj@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/damon/core.c

index 0776452a1abbb0562376636a63340892fd399fc8..5192ee29f6cfd657449a44c38895caeb8b0a97c6 100644 (file)
@@ -1550,7 +1550,7 @@ static unsigned long damos_quota_score(struct damos_quota *quota)
 static void damos_set_effective_quota(struct damos_quota *quota)
 {
        unsigned long throughput;
-       unsigned long esz;
+       unsigned long esz = ULONG_MAX;
 
        if (!quota->ms && list_empty(&quota->goals)) {
                quota->esz = quota->sz;
@@ -1572,10 +1572,7 @@ static void damos_set_effective_quota(struct damos_quota *quota)
                                quota->total_charged_ns;
                else
                        throughput = PAGE_SIZE * 1024;
-               if (!list_empty(&quota->goals))
-                       esz = min(throughput * quota->ms, esz);
-               else
-                       esz = throughput * quota->ms;
+               esz = min(throughput * quota->ms, esz);
        }
 
        if (quota->sz && quota->sz < esz)