ovpnmain.cgi: Move function to check CCD names here

This was in general-functions.pl for some reason.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

diff --git a/config/cfgroot/general-functions.pl b/config/cfgroot/general-functions.pl
index 8ba6e3f79f0a9660ba8f8630ad0c7f1a3f6c988d..86e9413d17f0ae7f102c110c492597b43d532f58 100644 (file)
--- a/config/cfgroot/general-functions.pl
+++ b/config/cfgroot/general-functions.pl
@@ -747,21 +747,6 @@ sub validhostname
        return 1;
 }
 
-sub validccdname
-{
-       # Checks a ccdname for letters, numbers and spaces
-        my $ccdname = $_[0];
-
-       # ccdname should be at least one character in length
-       # but no more than 63 characters
-       if (length ($ccdname) < 1 || length ($ccdname) > 63) {
-               return 0;}
-       # Only valid characters are a-z, A-Z, 0-9, space and -
-       if ($ccdname !~ /^[a-zA-Z0-9 -]*$/) {
-               return 0;}
-       return 1;
-}
-
 sub validdomainname
 {
        my $part;

diff --git a/html/cgi-bin/ovpnmain.cgi b/html/cgi-bin/ovpnmain.cgi
index 8d49d81e8c149b32a32edbc31004e129769ee72c..b0a97872094a1912212cca5696d88e1fd5465ac2 100755 (executable)
--- a/html/cgi-bin/ovpnmain.cgi
+++ b/html/cgi-bin/ovpnmain.cgi
@@ -350,6 +350,28 @@ sub writeserverconf {
     close(CONF);
 }
 
+##
+## CCD Name
+##
+
+# Checks a ccdname for letters, numbers and spaces
+sub validccdname($) {
+       my $name = shift;
+
+       # name should be at least one character in length
+       # but no more than 63 characters
+       if (length ($name) < 1 || length ($name) > 63) {
+               return 0;
+       }
+
+       # Only valid characters are a-z, A-Z, 0-9, space and -
+       if ($name !~ /^[a-zA-Z0-9 -]*$/) {
+               return 0;
+       }
+
+       return 1;
+}
+
 sub delccdnet($) {
        my $name = shift;
 
@@ -406,7 +428,7 @@ sub addccdnet
                return
        }
 
-       if(!&General::validccdname($ccdname))
+       if(!&validccdname($ccdname))
        {
                $errormessage=$Lang::tr{'ccd err invalidname'};
                return;
@@ -451,7 +473,7 @@ sub modccdnet
        my %ccdhash=();
 
        # Check if the new name is valid.
-       if(!&General::validccdname($newname)) {
+       if(!&validccdname($newname)) {
                $errormessage=$Lang::tr{'ccd err invalidname'};
                return;
        }