]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/msm: Avoid rounding up to one jiffy
authorRob Clark <robdclark@chromium.org>
Mon, 13 Jan 2025 15:48:41 +0000 (07:48 -0800)
committerRob Clark <robdclark@chromium.org>
Sat, 15 Feb 2025 17:24:02 +0000 (09:24 -0800)
If userspace is trying to achieve a timeout of zero, let 'em have it.
Only round up if the timeout is greater than zero.

Fixes: 4969bccd5f4e ("drm/msm: Avoid rounding down to zero jiffies")
Signed-off-by: Rob Clark <robdclark@chromium.org>
Reviewed-by: Akhil P Oommen <quic_akhilpo@quicinc.com>
Patchwork: https://patchwork.freedesktop.org/patch/632264/

drivers/gpu/drm/msm/msm_drv.h

index fee31680a6d540d87cada67342bd5bee721662df..a65077855201746c37ee742364b61116565f3794 100644 (file)
@@ -537,15 +537,12 @@ static inline int align_pitch(int width, int bpp)
 static inline unsigned long timeout_to_jiffies(const ktime_t *timeout)
 {
        ktime_t now = ktime_get();
-       s64 remaining_jiffies;
 
-       if (ktime_compare(*timeout, now) < 0) {
-               remaining_jiffies = 0;
-       } else {
-               ktime_t rem = ktime_sub(*timeout, now);
-               remaining_jiffies = ktime_divns(rem, NSEC_PER_SEC / HZ);
-       }
+       if (ktime_compare(*timeout, now) <= 0)
+               return 0;
 
+       ktime_t rem = ktime_sub(*timeout, now);
+       s64 remaining_jiffies = ktime_divns(rem, NSEC_PER_SEC / HZ);
        return clamp(remaining_jiffies, 1LL, (s64)INT_MAX);
 }