]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
ALSA: sh: Fix wrong argument order for copy_from_iter()
authorTakashi Iwai <tiwai@suse.de>
Fri, 20 Dec 2024 11:44:16 +0000 (12:44 +0100)
committerTakashi Iwai <tiwai@suse.de>
Fri, 20 Dec 2024 11:45:38 +0000 (12:45 +0100)
Fix a brown paper bag bug I introduced at converting to the standard
iter helper; the arguments were wrongly passed and have to be
swapped.

Fixes: 9b5f8ee43e48 ("ALSA: sh: Use standard helper for buffer accesses")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202412140019.jat5Dofr-lkp@intel.com/
Link: https://patch.msgid.link/20241220114417.5898-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/sh/sh_dac_audio.c

index a4d07438ad64b3b0e867fcc02df85c960fe2d3ea..3f5422145c5e248d19d50f383fd92e002e4e9eb0 100644 (file)
@@ -163,7 +163,7 @@ static int snd_sh_dac_pcm_copy(struct snd_pcm_substream *substream,
        /* channel is not used (interleaved data) */
        struct snd_sh_dac *chip = snd_pcm_substream_chip(substream);
 
-       if (copy_from_iter(chip->data_buffer + pos, src, count) != count)
+       if (copy_from_iter(chip->data_buffer + pos, count, src) != count)
                return -EFAULT;
        chip->buffer_end = chip->data_buffer + pos + count;