]> git.ipfire.org Git - thirdparty/xfsprogs-dev.git/commitdiff
xfs_metadump: agcount*agblocks overflow
authorEric Sandeen <sandeen@sandeen.net>
Mon, 6 Jul 2009 19:53:35 +0000 (14:53 -0500)
committerEric Sandeen <sandeen@sandeen.net>
Mon, 6 Jul 2009 19:53:35 +0000 (14:53 -0500)
Found another potential overflow in xfs_metadump,
similar to those just fixed in repair.

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Reviewed-by: Christoph Hellwig <hch@infradead.org>
--

db/metadump.c

index 19aed4f6ab098c60b807b7d19cf4e0a7bae612ab..ef6e571aab9b11a549a29f49d0a1d38ebc3280e8 100644 (file)
@@ -222,7 +222,8 @@ valid_bno(
                return 1;
        if (agno == (mp->m_sb.sb_agcount - 1) && agbno > 0 &&
                        agbno <= (mp->m_sb.sb_dblocks -
-                        (mp->m_sb.sb_agcount - 1) * mp->m_sb.sb_agblocks))
+                        (xfs_drfsbno_t)(mp->m_sb.sb_agcount - 1) *
+                        mp->m_sb.sb_agblocks))
                return 1;
 
        return 0;