]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
gpio: sifive: remove unneeded call to platform_set_drvdata()
authorAndrei Coardos <aboutphysycs@gmail.com>
Mon, 13 Nov 2023 02:34:32 +0000 (18:34 -0800)
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Wed, 15 Nov 2023 14:39:40 +0000 (15:39 +0100)
This function call was found to be unnecessary as there is no equivalent
platform_get_drvdata() call to access the private data of the driver. Also,
the private data is defined in this driver, so there is no risk of it being
accessed outside of this driver file.

Reviewed-by: Alexandru Ardelean <alex@shruggie.ro>
Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
Reviewed-by: Andy Shevchenko <andy@kernel.org>
Signed-off-by: Samuel Holland <samuel.holland@sifive.com>
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
drivers/gpio/gpio-sifive.c

index 8decd9b5d22983cd6faf8179e60ffd38f3053f3a..067c8edb62e2058e717c83a1942b9514d862ba55 100644 (file)
@@ -250,7 +250,6 @@ static int sifive_gpio_probe(struct platform_device *pdev)
        girq->handler = handle_bad_irq;
        girq->default_type = IRQ_TYPE_NONE;
 
-       platform_set_drvdata(pdev, chip);
        return gpiochip_add_data(&chip->gc, chip);
 }