]> git.ipfire.org Git - thirdparty/openldap.git/commitdiff
ITS#8677 back-sock: return error for CONTINUE
authorHoward Chu <hyc@openldap.org>
Thu, 2 Nov 2023 17:53:16 +0000 (17:53 +0000)
committerQuanah Gibson-Mount <quanah@openldap.org>
Tue, 14 Nov 2023 17:02:18 +0000 (17:02 +0000)
instead of asserting

servers/slapd/back-sock/result.c

index 439cea14a478a8d4ba6b1d65b7591f1978709ed0..dd56c181e2e3d10a8fc90981ec904d7906b3f04a 100644 (file)
@@ -81,7 +81,11 @@ sock_read_and_send_results(
                if ( strncasecmp( line, "CONTINUE", 8 ) == 0 ) {
                        struct sockinfo *si = (struct sockinfo *) op->o_bd->be_private;
                        /* Only valid when operating as an overlay! */
-                       assert( si->si_ops != 0 );
+                       if ( !si->si_ops ) {
+                               rs->sr_err = LDAP_OTHER;
+                               rs->sr_text = "CONTINUE is only valid when operating as an overlay";
+                               goto fail;
+                       }
                        rs->sr_err = SLAP_CB_CONTINUE;
                        goto skip;
                }