]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
libstdc++: Simplify std::variant comparison operators
authorJonathan Wakely <jwakely@redhat.com>
Thu, 28 Mar 2024 14:19:45 +0000 (14:19 +0000)
committerJonathan Wakely <jwakely@redhat.com>
Tue, 7 May 2024 13:44:36 +0000 (14:44 +0100)
libstdc++-v3/ChangeLog:

* include/std/variant (_VARIANT_RELATION_FUNCTION_TEMPLATE):
Simplify.

libstdc++-v3/include/std/variant

index 8072e1f17a85fe8b8de460a1b9c2483c454d8cc6..bf05eec9a6bfba3235907755fa23caaf25803406 100644 (file)
@@ -1245,7 +1245,7 @@ namespace __variant
 # define _VARIANT_RELATION_FUNCTION_CONSTRAINTS(TYPES, OP)
 #endif
 
-#define _VARIANT_RELATION_FUNCTION_TEMPLATE(__OP, __NAME) \
+#define _VARIANT_RELATION_FUNCTION_TEMPLATE(__OP) \
   template<typename... _Types> \
     _VARIANT_RELATION_FUNCTION_CONSTRAINTS(_Types, __OP) \
     constexpr bool \
@@ -1262,22 +1262,20 @@ namespace __variant
                { \
                  auto& __this_mem = std::get<__rhs_index>(__lhs);      \
                   __ret = __this_mem __OP __rhs_mem; \
+                 return; \
                 } \
-             else \
-               __ret = (__lhs.index() + 1) __OP (__rhs_index + 1); \
             } \
-          else \
-            __ret = (__lhs.index() + 1) __OP (__rhs_index + 1); \
+         __ret = (__lhs.index() + 1) __OP (__rhs_index + 1); \
        }, __rhs); \
       return __ret; \
     }
 
-  _VARIANT_RELATION_FUNCTION_TEMPLATE(<, less)
-  _VARIANT_RELATION_FUNCTION_TEMPLATE(<=, less_equal)
-  _VARIANT_RELATION_FUNCTION_TEMPLATE(==, equal)
-  _VARIANT_RELATION_FUNCTION_TEMPLATE(!=, not_equal)
-  _VARIANT_RELATION_FUNCTION_TEMPLATE(>=, greater_equal)
-  _VARIANT_RELATION_FUNCTION_TEMPLATE(>, greater)
+  _VARIANT_RELATION_FUNCTION_TEMPLATE(<)
+  _VARIANT_RELATION_FUNCTION_TEMPLATE(<=)
+  _VARIANT_RELATION_FUNCTION_TEMPLATE(==)
+  _VARIANT_RELATION_FUNCTION_TEMPLATE(!=)
+  _VARIANT_RELATION_FUNCTION_TEMPLATE(>=)
+  _VARIANT_RELATION_FUNCTION_TEMPLATE(>)
 
 #undef _VARIANT_RELATION_FUNCTION_TEMPLATE