]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
PM: sleep: Replace snprintf() with scnprintf() in show_trace_dev_match()
authorKaushlendra Kumar <kaushlendra.kumar@intel.com>
Mon, 22 Sep 2025 05:52:31 +0000 (11:22 +0530)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Mon, 13 Oct 2025 19:19:12 +0000 (21:19 +0200)
Replace snprintf() with scnprintf() in show_trace_dev_match() to simplify
buffer length handling. The scnprintf() function returns the number of
characters actually written (excluding the null terminator), which
eliminates the need for manual length checking and clamping.

This change removes the redundant size check since scnprintf() guarantees
that the return value will never exceed the buffer size, making the code
cleaner and less error-prone.

Signed-off-by: Kaushlendra Kumar <kaushlendra.kumar@intel.com>
Link: https://patch.msgid.link/20250922055231.3523680-1-kaushlendra.kumar@intel.com
[ rjw: Subject adjustment ]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/base/power/trace.c

index cd6e559648b21bd3661caed21573238f61038401..d8da7195bb00619ef633bd8f7f456b1f1baadea3 100644 (file)
@@ -238,10 +238,8 @@ int show_trace_dev_match(char *buf, size_t size)
                unsigned int hash = hash_string(DEVSEED, dev_name(dev),
                                                DEVHASH);
                if (hash == value) {
-                       int len = snprintf(buf, size, "%s\n",
+                       int len = scnprintf(buf, size, "%s\n",
                                            dev_driver_string(dev));
-                       if (len > size)
-                               len = size;
                        buf += len;
                        ret += len;
                        size -= len;