]> git.ipfire.org Git - thirdparty/kernel/stable-queue.git/commitdiff
3.4-stable patches
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 26 Feb 2013 18:06:27 +0000 (10:06 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 26 Feb 2013 18:06:27 +0000 (10:06 -0800)
added patches:
target-fix-divide-by-zero-bug-in-fabric_max_sectors-for-unconfigured-devices.patch

queue-3.4/series
queue-3.4/target-fix-divide-by-zero-bug-in-fabric_max_sectors-for-unconfigured-devices.patch [new file with mode: 0644]

index 1a156b0368cfb6b1b73dac97488a56cd97c5c318..913aa6c531f97eaf08f615d4cf27d2b2c19966c9 100644 (file)
@@ -48,3 +48,4 @@ drm-don-t-add-inferred-modes-for-monitors-that-don-t-support-them.patch
 drm-fill-depth-bits_per_pixel-for-c8-format.patch
 drm-use-c8-instead-of-rgb332-when-determining-the-format-from-depth-bpp.patch
 drm-usb-bind-driver-to-correct-device.patch
+target-fix-divide-by-zero-bug-in-fabric_max_sectors-for-unconfigured-devices.patch
diff --git a/queue-3.4/target-fix-divide-by-zero-bug-in-fabric_max_sectors-for-unconfigured-devices.patch b/queue-3.4/target-fix-divide-by-zero-bug-in-fabric_max_sectors-for-unconfigured-devices.patch
new file mode 100644 (file)
index 0000000..2dd8cca
--- /dev/null
@@ -0,0 +1,54 @@
+From nab@linux-iscsi.org  Tue Feb 26 10:03:15 2013
+From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
+Date: Tue, 19 Feb 2013 03:15:14 +0000
+Subject: target: Fix divide by zero bug in fabric_max_sectors for unconfigured devices
+To: target-devel <target-devel@vger.kernel.org>
+Cc: Nicholas Bellinger <nab@linux-iscsi.org>, Herton Ronaldo Krzesinski <herton.krzesinski@canonical.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+Message-ID: <1361243714-4765-1-git-send-email-nab@linux-iscsi.org>
+
+
+From: Nicholas Bellinger <nab@linux-iscsi.org>
+
+commit 7a3cf6ca1ab2a2f7161c6dec5a787fc7a5de864e upstream
+
+This patch fixes a possible divide by zero bug when the fabric_max_sectors
+device attribute is written and backend se_device failed to be successfully
+configured -> enabled.
+
+Go ahead and use block_size=512 within se_dev_set_fabric_max_sectors()
+in the event of a target_configure_device() failure case, as no valid
+dev->dev_attrib.block_size value will have been setup yet.
+
+Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
+Cc: Herton Ronaldo Krzesinski <herton.krzesinski@canonical.com>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+
+---
+ drivers/target/target_core_device.c |    8 +++++++-
+ 1 file changed, 7 insertions(+), 1 deletion(-)
+
+--- a/drivers/target/target_core_device.c
++++ b/drivers/target/target_core_device.c
+@@ -1230,6 +1230,8 @@ int se_dev_set_max_sectors(struct se_dev
+ int se_dev_set_fabric_max_sectors(struct se_device *dev, u32 fabric_max_sectors)
+ {
++      int block_size = dev->se_sub_dev->se_dev_attrib.block_size;
++
+       if (atomic_read(&dev->dev_export_obj.obj_access_count)) {
+               pr_err("dev[%p]: Unable to change SE Device"
+                       " fabric_max_sectors while dev_export_obj: %d count exists\n",
+@@ -1267,8 +1269,12 @@ int se_dev_set_fabric_max_sectors(struct
+       /*
+        * Align max_sectors down to PAGE_SIZE to follow transport_allocate_data_tasks()
+        */
++      if (!block_size) {
++              block_size = 512;
++              pr_warn("Defaulting to 512 for zero block_size\n");
++      }
+       fabric_max_sectors = se_dev_align_max_sectors(fabric_max_sectors,
+-                                                    dev->se_sub_dev->se_dev_attrib.block_size);
++                                                    block_size);
+       dev->se_sub_dev->se_dev_attrib.fabric_max_sectors = fabric_max_sectors;
+       pr_debug("dev[%p]: SE Device max_sectors changed to %u\n",