]> git.ipfire.org Git - thirdparty/xz.git/commitdiff
sysdefs.h: Don't include strings.h anymore.
authorLasse Collin <lasse.collin@tukaani.org>
Tue, 10 Jan 2023 09:56:11 +0000 (11:56 +0200)
committerLasse Collin <lasse.collin@tukaani.org>
Wed, 11 Jan 2023 15:49:59 +0000 (17:49 +0200)
On some platforms src/xz/suffix.c may need <strings.h> for
strcasecmp() but suffix.c includes the header when it needs it.

Unless there is an old system that otherwise supports enough C99
to build XZ Utils but doesn't have C89/C90-compatible <string.h>,
there should be no need to include <strings.h> in sysdefs.h.

src/common/sysdefs.h

index 2fbcd5933d3df6c2442bcc50b8080fa5d3eff7eb..97be4ee380d04ec84735f83cf3b00c8b4f3578ec 100644 (file)
@@ -149,14 +149,8 @@ typedef unsigned char _Bool;
 #      define __bool_true_false_are_defined 1
 #endif
 
-// string.h should be enough but let's include strings.h too if it exists
-// since that shouldn't do any harm but may improve portability.
 #include <string.h>
 
-#ifdef HAVE_STRINGS_H
-#      include <strings.h>
-#endif
-
 // As of MSVC 2013, inline and restrict are supported with
 // non-standard keywords.
 #if defined(_WIN32) && defined(_MSC_VER)