]> git.ipfire.org Git - thirdparty/git.git/commitdiff
transport-helper: do not run git-remote-ext etc. in dashed form
authorJunio C Hamano <gitster@pobox.com>
Wed, 26 Aug 2020 19:46:49 +0000 (12:46 -0700)
committerJunio C Hamano <gitster@pobox.com>
Wed, 26 Aug 2020 21:49:50 +0000 (14:49 -0700)
Running it as "git remote-ext" and letting "git" dispatch to
"remote-ext" would just be fine and is more idiomatic.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
transport-helper.c

index defafbf4c1bc6788c4f7b9692cdcfcda1181116b..c52c99d829d739047b867d2f431ab9eda48cb9dc 100644 (file)
@@ -128,10 +128,10 @@ static struct child_process *get_helper(struct transport *transport)
        helper->in = -1;
        helper->out = -1;
        helper->err = 0;
-       strvec_pushf(&helper->args, "git-remote-%s", data->name);
+       strvec_pushf(&helper->args, "remote-%s", data->name);
        strvec_push(&helper->args, transport->remote->name);
        strvec_push(&helper->args, remove_ext_force(transport->url));
-       helper->git_cmd = 0;
+       helper->git_cmd = 1;
        helper->silent_exec_failure = 1;
 
        if (have_git_dir())