]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/amdgpu: Fix signedness bug in sdma_v4_0_process_trap_irq()
authorDan Carpenter <dan.carpenter@linaro.org>
Sun, 28 Apr 2024 12:57:00 +0000 (15:57 +0300)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 30 Apr 2024 14:01:53 +0000 (10:01 -0400)
The "instance" variable needs to be signed for the error handling to work.

Fixes: 8b2faf1a4f3b ("drm/amdgpu: add error handle to avoid out-of-bounds")
Reviewed-by: Bob Zhou <bob.zhou@amd.com>
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c

index 101038395c3b45bf321213adb8c10b7ebcc15b61..772604feb6acdb44004a00302460e8b7cbb09b29 100644 (file)
@@ -2017,7 +2017,7 @@ static int sdma_v4_0_process_trap_irq(struct amdgpu_device *adev,
                                      struct amdgpu_irq_src *source,
                                      struct amdgpu_iv_entry *entry)
 {
-       uint32_t instance;
+       int instance;
 
        DRM_DEBUG("IH: SDMA trap\n");
        instance = sdma_v4_0_irq_id_to_seq(entry->client_id);