]> git.ipfire.org Git - thirdparty/git.git/commitdiff
git-p4 unshelve: adding a commit breaks git-p4 unshelve
authorLuke Diamand <luke@diamand.org>
Sat, 19 Sep 2020 08:54:40 +0000 (09:54 +0100)
committerJunio C Hamano <gitster@pobox.com>
Sat, 19 Sep 2020 20:44:54 +0000 (13:44 -0700)
git-p4 unshelve uses HEAD^$n to find the parent commit, which
fails if there is an additional commit.

Signed-off-by: Luke Diamand <luke@diamand.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/t9832-unshelve.sh

index e9276c48f4a2e795899a03681a737c70635ab39c..feda4499ddd5a4a0afddce501fafbf590edc35ca 100755 (executable)
@@ -29,8 +29,11 @@ test_expect_success 'init depot' '
        )
 '
 
+# Create an initial clone, with a commit unrelated to the P4 change
+# on HEAD
 test_expect_success 'initial clone' '
-       git p4 clone --dest="$git" //depot/@all
+       git p4 clone --dest="$git" //depot/@all &&
+    test_commit -C "$git" "unrelated"
 '
 
 test_expect_success 'create shelved changelist' '
@@ -77,7 +80,7 @@ EOF
        )
 '
 
-test_expect_success 'update shelved changelist and re-unshelve' '
+test_expect_failure 'update shelved changelist and re-unshelve' '
        test_when_finished cleanup_git &&
        (
                cd "$cli" &&