BUG/MEDIUM: httpclient/cli: free of unallocated hc->req.uri

httpclient_new() sets the hc->req.uri ist without duplicating its
memory, which is a problem since the string in the ist could be
inaccessible at some point. The API was made to use a ist which was
allocated dynamically, but httpclient_new() didn't do that, which result
in a crash when calling istfree().

This patch fixes the problem by doing an istdup()

Fix issue #1452.

diff --git a/src/http_client.c b/src/http_client.c
index fe85f050b80489f2e75cb0d9609955090d427f22..4e5ef7c1c7fbb6ff30019771631a38e34b174d8c 100644 (file)
--- a/src/http_client.c
+++ b/src/http_client.c
@@ -535,7 +535,7 @@ struct httpclient *httpclient_new(void *caller, enum http_meth_t meth, struct is
                goto err;
 
        hc->caller = caller;
-       hc->req.url = url;
+       hc->req.url = istdup(url);
        hc->req.meth = meth;
 
        return hc;