]> git.ipfire.org Git - thirdparty/dovecot/core.git/commitdiff
lib-lua: dlua_script_init() - Always return -1 if script_init() fails
authorTimo Sirainen <timo.sirainen@open-xchange.com>
Fri, 21 May 2021 14:06:37 +0000 (17:06 +0300)
committeraki.tuomi <aki.tuomi@open-xchange.com>
Tue, 1 Jun 2021 09:35:08 +0000 (09:35 +0000)
The previous behavior was to forward the script_init() return value to
the caller. This was somewhat unexpected behavior.

src/lib-lua/dlua-script.c

index 822eb0ca83b5aed119cc1f47b0a7665dac337a7d..a0c5d4ef2e968d338338e85bf37ef9659404fce1 100644 (file)
@@ -173,8 +173,10 @@ int dlua_script_init(struct dlua_script *script, const char **error_r)
 
        if (lua_isinteger(script->L, -1)) {
                ret = lua_tointeger(script->L, -1);
-               if (ret != 0)
+               if (ret != 0) {
                        *error_r = "Script init failed";
+                       ret = -1;
+               }
        } else {
                *error_r = LUA_SCRIPT_INIT_FN"() returned non-number";
                ret = -1;