]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
tty: n_tty: drop n_tty_trace()
authorJiri Slaby (SUSE) <jirislaby@kernel.org>
Mon, 17 Mar 2025 07:00:23 +0000 (08:00 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 20 Mar 2025 15:00:50 +0000 (08:00 -0700)
This n_tty_trace() is an always disabled debugging macro. It comes from
commit 32f13521ca68 ("n_tty: Line copy to user buffer in canonical
mode").

Drop it as it is dead for over a decade.

Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
Link: https://lore.kernel.org/r/20250317070046.24386-9-jirislaby@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/n_tty.c

index 5d172edbb03c67063a8872f88300a2ff2581babe..43ba740792d924b9ab609aab75efee5b5cbe088e 100644 (file)
 #define ECHO_BLOCK             256
 #define ECHO_DISCARD_WATERMARK N_TTY_BUF_SIZE - (ECHO_BLOCK + 32)
 
-
-#undef N_TTY_TRACE
-#ifdef N_TTY_TRACE
-# define n_tty_trace(f, args...)       trace_printk(f, ##args)
-#else
-# define n_tty_trace(f, args...)       no_printk(f, ##args)
-#endif
-
 struct n_tty_data {
        /* producer-published */
        size_t read_head;
@@ -2026,9 +2018,6 @@ static bool canon_copy_from_read_buf(const struct tty_struct *tty, u8 **kbp,
        tail = MASK(ldata->read_tail);
        size = min_t(size_t, tail + n, N_TTY_BUF_SIZE);
 
-       n_tty_trace("%s: nr:%zu tail:%zu n:%zu size:%zu\n",
-                   __func__, *nr, tail, n, size);
-
        eol = find_next_bit(ldata->read_flags, size, tail);
        more = n - (size - tail);
        if (eol == N_TTY_BUF_SIZE && more) {
@@ -2046,9 +2035,6 @@ static bool canon_copy_from_read_buf(const struct tty_struct *tty, u8 **kbp,
        if (!found || read_buf(ldata, eol) != __DISABLED_CHAR)
                n = c;
 
-       n_tty_trace("%s: eol:%zu found:%d n:%zu c:%zu tail:%zu more:%zu\n",
-                   __func__, eol, found, n, c, tail, more);
-
        tty_copy(tty, *kbp, tail, n);
        *kbp += n;
        *nr -= n;