]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ipmi_si: remove ipmi_smi_alloc() function
authorCorey Minyard <cminyard@mvista.com>
Wed, 13 Sep 2017 04:35:39 +0000 (23:35 -0500)
committerCorey Minyard <cminyard@mvista.com>
Thu, 28 Sep 2017 17:26:01 +0000 (12:26 -0500)
It's only used in one place now, so it's overkill.

Signed-off-by: Corey Minyard <cminyard@mvista.com>
drivers/char/ipmi/ipmi_si_intf.c

index d24cd5de09d06a3aab016c706a898c09d8ea50fa..3758560a6ab2d9a4bfbe6a556bf711bf9c8b00b6 100644 (file)
@@ -1302,15 +1302,6 @@ int ipmi_std_irq_setup(struct si_sm_io *io)
        return rv;
 }
 
-static struct smi_info *smi_info_alloc(void)
-{
-       struct smi_info *info = kzalloc(sizeof(*info), GFP_KERNEL);
-
-       if (info)
-               spin_lock_init(&info->si_lock);
-       return info;
-}
-
 static int wait_for_msg_done(struct smi_info *smi_info)
 {
        enum si_sm_result     smi_result;
@@ -1902,9 +1893,10 @@ int ipmi_si_add_smi(struct si_sm_io *io)
                }
        }
 
-       new_smi = smi_info_alloc();
+       new_smi = kzalloc(sizeof(*new_smi), GFP_KERNEL);
        if (!new_smi)
                return -ENOMEM;
+       spin_lock_init(&new_smi->si_lock);
 
        new_smi->io = *io;