tree-vect-patterns.c (vect_recog_rotate_pattern): For vect_external_def oprnd1 with...

	* tree-vect-patterns.c (vect_recog_rotate_pattern): For
	vect_external_def oprnd1 with loop_vinfo, try to emit
	optional cast, negation and and stmts on the loop preheader
	edge instead of into the pattern def seq.

	* gcc.target/i386/rotate-4.c: Compile only with -mavx
	instead of -mavx2, require only avx instead of avx2.
	* gcc.target/i386/rotate-4a.c: Include avx-check.h instead
	of avx2-check.h and turn into an avx runtime test instead of
	avx2 runtime test.

From-SVN: r199005

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index e537c4bd00991d208bca117d5ff4f51f5fa211f3..0394c0ee87eb6f5de0da9685ae9852d396eb81ce 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,5 +1,10 @@
 2013-05-17  Jakub Jelinek  <jakub@redhat.com>
 
+       * tree-vect-patterns.c (vect_recog_rotate_pattern): For
+       vect_external_def oprnd1 with loop_vinfo, try to emit
+       optional cast, negation and and stmts on the loop preheader
+       edge instead of into the pattern def seq.
+
        PR tree-optimization/57051
        * fold-const.c (const_binop) <case VEC_LSHIFT_EXPR,
        case VEC_RSHIFT_EXPR>: Fix BYTES_BIG_ENDIAN handling.

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index d742559afa9fe555b09afa15ffe543b36fbb122a..8635b0b72e29dc75f8518eb0c0b83e02750545e1 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,11 @@
+2013-05-17  Jakub Jelinek  <jakub@redhat.com>
+
+       * gcc.target/i386/rotate-4.c: Compile only with -mavx
+       instead of -mavx2, require only avx instead of avx2.
+       * gcc.target/i386/rotate-4a.c: Include avx-check.h instead
+       of avx2-check.h and turn into an avx runtime test instead of
+       avx2 runtime test.
+
 2013-05-16  Marc Glisse  <marc.glisse@inria.fr>
 
        * g++.dg/ext/vector22.C: Uncomment working test.

diff --git a/gcc/testsuite/gcc.target/i386/rotate-4.c b/gcc/testsuite/gcc.target/i386/rotate-4.c
index 0f8fdee07d736abb76ae30d082ce38a6f2599a7d..7faa052cbff5b23fb758bb96d723337d1a831694 100644 (file)
--- a/gcc/testsuite/gcc.target/i386/rotate-4.c
+++ b/gcc/testsuite/gcc.target/i386/rotate-4.c
@@ -1,6 +1,6 @@
 /* { dg-do compile } */
-/* { dg-require-effective-target avx2 } */
-/* { dg-options "-O3 -mavx2 -fdump-tree-vect-details" } */
+/* { dg-require-effective-target avx } */
+/* { dg-options "-O3 -mavx -fdump-tree-vect-details" } */
 /* { dg-final { scan-tree-dump-times "vectorized 1 loops" 1 "vect" } } */
 /* { dg-final { cleanup-tree-dump "vect" } } */
 

diff --git a/gcc/testsuite/gcc.target/i386/rotate-4a.c b/gcc/testsuite/gcc.target/i386/rotate-4a.c
index bc69d206aa5ea2375010820f0b2368f14c65ce0f..3da440fb78c8a1d837f287e717bcbfdc2ac9da5d 100644 (file)
--- a/gcc/testsuite/gcc.target/i386/rotate-4a.c
+++ b/gcc/testsuite/gcc.target/i386/rotate-4a.c
@@ -1,14 +1,14 @@
 /* { dg-do run } */
-/* { dg-require-effective-target avx2 } */
-/* { dg-options "-O3 -mavx2" } */
+/* { dg-require-effective-target avx } */
+/* { dg-options "-O3 -mavx" } */
 
-#include "avx2-check.h"
+#include "avx-check.h"
 
 #include "rotate-4.c"
 
 static void
 __attribute__((noinline))
-avx2_test (void)
+avx_test (void)
 {
   int i;
   for (i = 0; i < 1024; i++)

diff --git a/gcc/tree-vect-patterns.c b/gcc/tree-vect-patterns.c
index dacfb87998efc57016ee9f1becd4be295b35d5c4..648385a9b0cabe9a1c7d53db8a2a5a51c2536f2e 100644 (file)
--- a/gcc/tree-vect-patterns.c
+++ b/gcc/tree-vect-patterns.c
@@ -1494,6 +1494,7 @@ vect_recog_rotate_pattern (vec<gimple> *stmts, tree *type_in, tree *type_out)
   bb_vec_info bb_vinfo = STMT_VINFO_BB_VINFO (stmt_vinfo);
   enum vect_def_type dt;
   optab optab1, optab2;
+  edge ext_def = NULL;
 
   if (!is_gimple_assign (last_stmt))
     return NULL;
@@ -1574,6 +1575,21 @@ vect_recog_rotate_pattern (vec<gimple> *stmts, tree *type_in, tree *type_out)
   if (*type_in == NULL_TREE)
     return NULL;
 
+  if (dt == vect_external_def
+      && TREE_CODE (oprnd1) == SSA_NAME
+      && loop_vinfo)
+    {
+      struct loop *loop = LOOP_VINFO_LOOP (loop_vinfo);
+      ext_def = loop_preheader_edge (loop);
+      if (!SSA_NAME_IS_DEFAULT_DEF (oprnd1))
+       {
+         basic_block bb = gimple_bb (SSA_NAME_DEF_STMT (oprnd1));
+         if (bb == NULL
+             || !dominated_by_p (CDI_DOMINATORS, ext_def->dest, bb))
+           ext_def = NULL;
+       }
+    }
+
   def = NULL_TREE;
   if (TREE_CODE (oprnd1) == INTEGER_CST
       || TYPE_MODE (TREE_TYPE (oprnd1)) == TYPE_MODE (type))
@@ -1593,7 +1609,14 @@ vect_recog_rotate_pattern (vec<gimple> *stmts, tree *type_in, tree *type_out)
       def = vect_recog_temp_ssa_var (type, NULL);
       def_stmt = gimple_build_assign_with_ops (NOP_EXPR, def, oprnd1,
                                               NULL_TREE);
-      append_pattern_def_seq (stmt_vinfo, def_stmt);
+      if (ext_def)
+       {
+         basic_block new_bb
+           = gsi_insert_on_edge_immediate (ext_def, def_stmt);
+         gcc_assert (!new_bb);
+       }
+      else
+       append_pattern_def_seq (stmt_vinfo, def_stmt);
     }
   stype = TREE_TYPE (def);
 
@@ -1618,11 +1641,19 @@ vect_recog_rotate_pattern (vec<gimple> *stmts, tree *type_in, tree *type_out)
       def2 = vect_recog_temp_ssa_var (stype, NULL);
       def_stmt = gimple_build_assign_with_ops (NEGATE_EXPR, def2, def,
                                               NULL_TREE);
-      def_stmt_vinfo
-       = new_stmt_vec_info (def_stmt, loop_vinfo, bb_vinfo);
-      set_vinfo_for_stmt (def_stmt, def_stmt_vinfo);
-      STMT_VINFO_VECTYPE (def_stmt_vinfo) = vecstype;
-      append_pattern_def_seq (stmt_vinfo, def_stmt);
+      if (ext_def)
+       {
+         basic_block new_bb
+           = gsi_insert_on_edge_immediate (ext_def, def_stmt);
+         gcc_assert (!new_bb);
+       }
+      else
+       {
+         def_stmt_vinfo = new_stmt_vec_info (def_stmt, loop_vinfo, bb_vinfo);
+         set_vinfo_for_stmt (def_stmt, def_stmt_vinfo);
+         STMT_VINFO_VECTYPE (def_stmt_vinfo) = vecstype;
+         append_pattern_def_seq (stmt_vinfo, def_stmt);
+       }
 
       def2 = vect_recog_temp_ssa_var (stype, NULL);
       tree mask
@@ -1630,11 +1661,19 @@ vect_recog_rotate_pattern (vec<gimple> *stmts, tree *type_in, tree *type_out)
       def_stmt = gimple_build_assign_with_ops (BIT_AND_EXPR, def2,
                                               gimple_assign_lhs (def_stmt),
                                               mask);
-      def_stmt_vinfo
-       = new_stmt_vec_info (def_stmt, loop_vinfo, bb_vinfo);
-      set_vinfo_for_stmt (def_stmt, def_stmt_vinfo);
-      STMT_VINFO_VECTYPE (def_stmt_vinfo) = vecstype;
-      append_pattern_def_seq (stmt_vinfo, def_stmt);
+      if (ext_def)
+       {
+         basic_block new_bb
+           = gsi_insert_on_edge_immediate (ext_def, def_stmt);
+         gcc_assert (!new_bb);
+       }
+      else
+       {
+         def_stmt_vinfo = new_stmt_vec_info (def_stmt, loop_vinfo, bb_vinfo);
+         set_vinfo_for_stmt (def_stmt, def_stmt_vinfo);
+         STMT_VINFO_VECTYPE (def_stmt_vinfo) = vecstype;
+         append_pattern_def_seq (stmt_vinfo, def_stmt);
+       }
     }
 
   var1 = vect_recog_temp_ssa_var (type, NULL);