]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
pinctrl: bcm281xx: Fix incorrect regmap max_registers value
authorArtur Weber <aweber.kernel@gmail.com>
Fri, 7 Feb 2025 20:02:41 +0000 (21:02 +0100)
committerLinus Walleij <linus.walleij@linaro.org>
Tue, 25 Feb 2025 16:21:50 +0000 (17:21 +0100)
The max_registers value does not take into consideration the stride;
currently, it's set to the number of the last pin, but this does not
accurately represent the final register.

Fix this by multiplying the current value by 4.

Fixes: 54b1aa5a5b16 ("ARM: pinctrl: Add Broadcom Capri pinctrl driver")
Signed-off-by: Artur Weber <aweber.kernel@gmail.com>
Link: https://lore.kernel.org/20250207-bcm21664-pinctrl-v1-2-e7cfac9b2d3b@gmail.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/bcm/pinctrl-bcm281xx.c

index 73dbf29c002f39cde71352c1bf806872dd218b62..cf6efa9c0364a1ad65885c982e7634f26d19c944 100644 (file)
@@ -974,7 +974,7 @@ static const struct regmap_config bcm281xx_pinctrl_regmap_config = {
        .reg_bits = 32,
        .reg_stride = 4,
        .val_bits = 32,
-       .max_register = BCM281XX_PIN_VC_CAM3_SDA,
+       .max_register = BCM281XX_PIN_VC_CAM3_SDA * 4,
 };
 
 static int bcm281xx_pinctrl_get_groups_count(struct pinctrl_dev *pctldev)