]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
net: altera-tse: Set platform drvdata before registering netdev
authorMaxime Chevallier <maxime.chevallier@bootlin.com>
Mon, 3 Nov 2025 10:49:24 +0000 (11:49 +0100)
committerJakub Kicinski <kuba@kernel.org>
Wed, 5 Nov 2025 02:15:14 +0000 (18:15 -0800)
We don't have to wait until netdev is registered before setting it as the
pdev's drvdata. Move it at netdev alloc time.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
Link: https://patch.msgid.link/20251103104928.58461-2-maxime.chevallier@bootlin.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/altera/altera_tse_main.c

index 3f6204de9e6b802ad6f0b702a0947d2dbcd5518a..6ba1249f027df6bf463e6dc567045bc735b4061d 100644 (file)
@@ -1150,6 +1150,7 @@ static int altera_tse_probe(struct platform_device *pdev)
        }
 
        SET_NETDEV_DEV(ndev, &pdev->dev);
+       platform_set_drvdata(pdev, ndev);
 
        priv = netdev_priv(ndev);
        priv->device = &pdev->dev;
@@ -1394,8 +1395,6 @@ static int altera_tse_probe(struct platform_device *pdev)
                goto err_register_netdev;
        }
 
-       platform_set_drvdata(pdev, ndev);
-
        priv->revision = ioread32(&priv->mac_dev->megacore_revision);
 
        if (netif_msg_probe(priv))