]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
media: allgro-dvt: Drop unneeded v4l2_m2m_get_vq() NULL check
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Wed, 15 Oct 2025 07:53:25 +0000 (10:53 +0300)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Fri, 17 Oct 2025 09:31:14 +0000 (11:31 +0200)
The v4l2_m2m_get_vq() function never returns NULL. The check may have
been intended to catch invalid format types, but that's not needed as
the V4L2 core picks the appropriate VIDIOC_S_FMT ioctl handler based on
the format type, so the type can't be incorrect. Drop the unneeded
return value check.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/platform/allegro-dvt/allegro-core.c

index 510c3c9661d990c8ae97d4b4d174639b5aa0b13d..875e5cbbeb07d339ee7b1348aa6edcb9133120ac 100644 (file)
@@ -3333,8 +3333,6 @@ static int allegro_s_fmt_vid_cap(struct file *file, void *fh,
                return err;
 
        vq = v4l2_m2m_get_vq(channel->fh.m2m_ctx, f->type);
-       if (!vq)
-               return -EINVAL;
        if (vb2_is_busy(vq))
                return -EBUSY;