]> git.ipfire.org Git - thirdparty/git.git/commitdiff
builtin/fmt-merge-msg: fix leaking buffers
authorPatrick Steinhardt <ps@pks.im>
Thu, 5 Sep 2024 10:09:34 +0000 (12:09 +0200)
committerJunio C Hamano <gitster@pobox.com>
Thu, 5 Sep 2024 15:49:12 +0000 (08:49 -0700)
Fix leaking input and output buffers in git-fmt-merge-msg(1).

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/fmt-merge-msg.c
t/t6200-fmt-merge-msg.sh

index 957786d1b3ae7ba9b9d51b0b403c42bb00aba064..0b162f8fab15784cc04752b3d8de9ebe620beddf 100644 (file)
@@ -67,6 +67,8 @@ int cmd_fmt_merge_msg(int argc, const char **argv, const char *prefix)
                return ret;
        write_in_full(STDOUT_FILENO, output.buf, output.len);
 
+       strbuf_release(&input);
+       strbuf_release(&output);
        free(inpath);
        return 0;
 }
index 5a221f8ef1fd810731a4dd8b0d5cdab988084ed8..ac57b0e4ae37698f10cd53a612c8043c4f85acda 100755 (executable)
@@ -8,6 +8,7 @@ test_description='fmt-merge-msg test'
 GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
 export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./test-lib.sh
 . "$TEST_DIRECTORY/lib-gpg.sh"