leds: leds-pca995x: Add support for NXP PCA9956B

Add support for PCA9956B chip, which belongs to the same family.

This chip features 24 instead of 16 outputs, so add a chipdef struct to
deal with the different register layouts.

Reviewed-by: Marek Vasut <marex@denx.de>
Signed-off-by: Pieterjan Camerlynck <pieterjanca@gmail.com>
Link: https://lore.kernel.org/r/20240711-pca995x-v4-2-702a67148065@gmail.com
Signed-off-by: Lee Jones <lee@kernel.org>

diff --git a/drivers/leds/leds-pca995x.c b/drivers/leds/leds-pca995x.c
index 78215dff14997c931e6879dda136550241cf120d..686b77772ccecaddc74dd5aa1817faaef1709d7c 100644 (file)
--- a/drivers/leds/leds-pca995x.c
+++ b/drivers/leds/leds-pca995x.c
@@ -19,10 +19,6 @@
 #define PCA995X_MODE1                  0x00
 #define PCA995X_MODE2                  0x01
 #define PCA995X_LEDOUT0                        0x02
-#define PCA9955B_PWM0                  0x08
-#define PCA9952_PWM0                   0x0A
-#define PCA9952_IREFALL                        0x43
-#define PCA9955B_IREFALL               0x45
 
 /* Auto-increment disabled. Normal mode */
 #define PCA995X_MODE1_CFG              0x00
@@ -34,17 +30,38 @@
 #define PCA995X_LDRX_MASK              0x3
 #define PCA995X_LDRX_BITS              2
 
-#define PCA995X_MAX_OUTPUTS            16
+#define PCA995X_MAX_OUTPUTS            24
 #define PCA995X_OUTPUTS_PER_REG                4
 
 #define PCA995X_IREFALL_FULL_CFG       0xFF
 #define PCA995X_IREFALL_HALF_CFG       (PCA995X_IREFALL_FULL_CFG / 2)
 
-#define PCA995X_TYPE_NON_B             0
-#define PCA995X_TYPE_B                 1
-
 #define ldev_to_led(c) container_of(c, struct pca995x_led, ldev)
 
+struct pca995x_chipdef {
+       unsigned int num_leds;
+       u8 pwm_base;
+       u8 irefall;
+};
+
+static const struct pca995x_chipdef pca9952_chipdef = {
+       .num_leds       = 16,
+       .pwm_base       = 0x0a,
+       .irefall        = 0x43,
+};
+
+static const struct pca995x_chipdef pca9955b_chipdef = {
+       .num_leds       = 16,
+       .pwm_base       = 0x08,
+       .irefall        = 0x45,
+};
+
+static const struct pca995x_chipdef pca9956b_chipdef = {
+       .num_leds       = 24,
+       .pwm_base       = 0x0a,
+       .irefall        = 0x40,
+};
+
 struct pca995x_led {
        unsigned int led_no;
        struct led_classdev ldev;
@@ -54,7 +71,7 @@ struct pca995x_led {
 struct pca995x_chip {
        struct regmap *regmap;
        struct pca995x_led leds[PCA995X_MAX_OUTPUTS];
-       int btype;
+       const struct pca995x_chipdef *chipdef;
 };
 
 static int pca995x_brightness_set(struct led_classdev *led_cdev,
@@ -62,10 +79,11 @@ static int pca995x_brightness_set(struct led_classdev *led_cdev,
 {
        struct pca995x_led *led = ldev_to_led(led_cdev);
        struct pca995x_chip *chip = led->chip;
+       const struct pca995x_chipdef *chipdef = chip->chipdef;
        u8 ledout_addr, pwmout_addr;
        int shift, ret;
 
-       pwmout_addr = (chip->btype ? PCA9955B_PWM0 : PCA9952_PWM0) + led->led_no;
+       pwmout_addr = chipdef->pwm_base + led->led_no;
        ledout_addr = PCA995X_LEDOUT0 + (led->led_no / PCA995X_OUTPUTS_PER_REG);
        shift = PCA995X_LDRX_BITS * (led->led_no % PCA995X_OUTPUTS_PER_REG);
 
@@ -104,11 +122,12 @@ static int pca995x_probe(struct i2c_client *client)
        struct fwnode_handle *led_fwnodes[PCA995X_MAX_OUTPUTS] = { 0 };
        struct fwnode_handle *np, *child;
        struct device *dev = &client->dev;
+       const struct pca995x_chipdef *chipdef;
        struct pca995x_chip *chip;
        struct pca995x_led *led;
-       int i, btype, reg, ret;
+       int i, reg, ret;
 
-       btype = (unsigned long)device_get_match_data(&client->dev);
+       chipdef = device_get_match_data(&client->dev);
 
        np = dev_fwnode(dev);
        if (!np)
@@ -118,7 +137,7 @@ static int pca995x_probe(struct i2c_client *client)
        if (!chip)
                return -ENOMEM;
 
-       chip->btype = btype;
+       chip->chipdef = chipdef;
        chip->regmap = devm_regmap_init_i2c(client, &pca995x_regmap);
        if (IS_ERR(chip->regmap))
                return PTR_ERR(chip->regmap);
@@ -170,21 +189,21 @@ static int pca995x_probe(struct i2c_client *client)
                return ret;
 
        /* IREF Output current value for all LEDn outputs */
-       return regmap_write(chip->regmap,
-                           btype ? PCA9955B_IREFALL : PCA9952_IREFALL,
-                           PCA995X_IREFALL_HALF_CFG);
+       return regmap_write(chip->regmap, chipdef->irefall, PCA995X_IREFALL_HALF_CFG);
 }
 
 static const struct i2c_device_id pca995x_id[] = {
-       { "pca9952", .driver_data = (kernel_ulong_t)PCA995X_TYPE_NON_B },
-       { "pca9955b", .driver_data = (kernel_ulong_t)PCA995X_TYPE_B },
+       { "pca9952", .driver_data = (kernel_ulong_t)&pca9952_chipdef },
+       { "pca9955b", .driver_data = (kernel_ulong_t)&pca9955b_chipdef },
+       { "pca9956b", .driver_data = (kernel_ulong_t)&pca9956b_chipdef },
        {}
 };
 MODULE_DEVICE_TABLE(i2c, pca995x_id);
 
 static const struct of_device_id pca995x_of_match[] = {
-       { .compatible = "nxp,pca9952",  .data = (void *)PCA995X_TYPE_NON_B },
-       { .compatible = "nxp,pca9955b", .data = (void *)PCA995X_TYPE_B },
+       { .compatible = "nxp,pca9952", .data = &pca9952_chipdef },
+       { .compatible = "nxp,pca9955b", . data = &pca9955b_chipdef },
+       { .compatible = "nxp,pca9956b", .data = &pca9956b_chipdef },
        {},
 };
 MODULE_DEVICE_TABLE(of, pca995x_of_match);