]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
sched_ext: switch class when preempted by higher priority scheduler
authorHonglei Wang <jameshongleiwang@126.com>
Wed, 8 Jan 2025 02:33:28 +0000 (10:33 +0800)
committerTejun Heo <tj@kernel.org>
Wed, 8 Jan 2025 16:51:40 +0000 (06:51 -1000)
ops.cpu_release() function, if defined, must be invoked when preempted by
a higher priority scheduler class task. This scenario was skipped in
commit f422316d7466 ("sched_ext: Remove switch_class_scx()"). Let's fix
it.

Fixes: f422316d7466 ("sched_ext: Remove switch_class_scx()")
Signed-off-by: Honglei Wang <jameshongleiwang@126.com>
Acked-by: Andrea Righi <arighi@nvidia.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
kernel/sched/ext.c

index 11a0e1a9d86ef680211167ef62042b7b747ad305..68150e110451161918b44ba69d173c0759a2f9d2 100644 (file)
@@ -3037,7 +3037,7 @@ static void put_prev_task_scx(struct rq *rq, struct task_struct *p,
                 */
                if (p->scx.slice && !scx_rq_bypassing(rq)) {
                        dispatch_enqueue(&rq->scx.local_dsq, p, SCX_ENQ_HEAD);
-                       return;
+                       goto switch_class;
                }
 
                /*
@@ -3054,6 +3054,7 @@ static void put_prev_task_scx(struct rq *rq, struct task_struct *p,
                }
        }
 
+switch_class:
        if (next && next->sched_class != &ext_sched_class)
                switch_class(rq, next);
 }