]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
f2fs: clean up to check bi_status w/ BLK_STS_OK
authorChao Yu <chao@kernel.org>
Fri, 23 May 2025 07:33:04 +0000 (15:33 +0800)
committerJaegeuk Kim <jaegeuk@kernel.org>
Wed, 28 May 2025 16:03:39 +0000 (16:03 +0000)
Check bi_status w/ BLK_STS_OK instead of 0 for cleanup.

Signed-off-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
fs/f2fs/compress.c
fs/f2fs/data.c

index 0dc65634cc6123efea1a1b031ec4bcd97059c240..b3c1df93a163c631f2d4a42526b945e49af9c708 100644 (file)
@@ -1483,7 +1483,7 @@ void f2fs_compress_write_end_io(struct bio *bio, struct page *page)
                                f2fs_is_compressed_page(page));
        int i;
 
-       if (unlikely(bio->bi_status))
+       if (unlikely(bio->bi_status != BLK_STS_OK))
                mapping_set_error(cic->inode->i_mapping, -EIO);
 
        f2fs_compress_free_page(page);
index 1be38186076da07d8bcc90b5681599e8b193c412..31e892842625928d5731a02670f7d137cb902a4a 100644 (file)
@@ -151,7 +151,7 @@ static void f2fs_finish_read_bio(struct bio *bio, bool in_task)
                }
 
                dec_page_count(F2FS_F_SB(folio), __read_io_type(folio));
-               folio_end_read(folio, bio->bi_status == 0);
+               folio_end_read(folio, bio->bi_status == BLK_STS_OK);
        }
 
        if (ctx)
@@ -290,7 +290,7 @@ static void f2fs_read_end_io(struct bio *bio)
        if (time_to_inject(sbi, FAULT_READ_IO))
                bio->bi_status = BLK_STS_IOERR;
 
-       if (bio->bi_status) {
+       if (bio->bi_status != BLK_STS_OK) {
                f2fs_finish_read_bio(bio, intask);
                return;
        }
@@ -347,7 +347,7 @@ static void f2fs_write_end_io(struct bio *bio)
 
                type = WB_DATA_TYPE(&folio->page, false);
 
-               if (unlikely(bio->bi_status)) {
+               if (unlikely(bio->bi_status != BLK_STS_OK)) {
                        mapping_set_error(folio->mapping, -EIO);
                        if (type == F2FS_WB_CP_DATA)
                                f2fs_stop_checkpoint(sbi, true,