]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ata: libata-sata: Remove superfluous assignment in ata_sas_port_alloc()
authorNiklas Cassel <cassel@kernel.org>
Wed, 3 Jul 2024 18:44:21 +0000 (20:44 +0200)
committerNiklas Cassel <cassel@kernel.org>
Thu, 4 Jul 2024 09:52:32 +0000 (11:52 +0200)
ata_sas_port_alloc() calls ata_port_alloc() which already assigns ap->lock
so there is no need for ata_sas_port_alloc() to assign it again.

Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Link: https://lore.kernel.org/r/20240703184418.723066-15-cassel@kernel.org
Signed-off-by: Niklas Cassel <cassel@kernel.org>
drivers/ata/libata-sata.c

index e7991595bfe51363dd20b9c56a860f78fc4e9d22..1a36a5d1d7bc2424ec785ce700d52703dc4d77a1 100644 (file)
@@ -1228,7 +1228,6 @@ struct ata_port *ata_sas_port_alloc(struct ata_host *host,
                return NULL;
 
        ap->port_no = 0;
-       ap->lock = &host->lock;
        ap->pio_mask = port_info->pio_mask;
        ap->mwdma_mask = port_info->mwdma_mask;
        ap->udma_mask = port_info->udma_mask;