lib: Change event_set_forced_debug(e, FALSE) to be a no-op

diff --git a/src/lib/event-log.c b/src/lib/event-log.c
index 4f18ecc8dc0ec70e79ef584d3f2341731d61ba2a..0bab226fa8dbce979ff2c233c756bbc1228bf035 100644 (file)
--- a/src/lib/event-log.c
+++ b/src/lib/event-log.c
@@ -206,7 +206,8 @@ void event_logv(struct event *event, const struct event_log_params *params,
 
 struct event *event_set_forced_debug(struct event *event, bool force)
 {
-       event->forced_debug = force;
+       if (force)
+               event->forced_debug = TRUE;
        return event;
 }
 

diff --git a/src/lib/event-log.h b/src/lib/event-log.h
index 77f61805f0e2e0ba0a1b764c5f161b47ee9e28bd..b11999089bbabcd73212a82bfc84f5b8fe1ab5b0 100644 (file)
--- a/src/lib/event-log.h
+++ b/src/lib/event-log.h
@@ -58,12 +58,8 @@ void event_logv(struct event *event, const struct event_log_params *params,
    afterwards. It doesn't apply to existing child events (mainly for
    performance reasons).
 
-   Note that it's always recommended to use e.g.:
-     if (set->debug) event_set_forced_debug(event, TRUE); // good
-   instead of
-     event_set_forced_debug(event, set->debug); // bad
-   This is because the event may already have had debugging enabled via the
-   parent event. Forcing it to FALSE is most likely not wanted. */
+   Note that event_set_forced_debug(event, FALSE) is a no-op. To disable
+   forced-debug, use event_unset_forced_debug(event). */
 struct event *event_set_forced_debug(struct event *event, bool force);
 /* Set the forced-debug to FALSE */
 struct event *event_unset_forced_debug(struct event *event);