]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
testsuite: scev: expect fail on ilp32
authorAlexandre Oliva <oliva@adacore.com>
Mon, 20 Nov 2023 08:14:25 +0000 (05:14 -0300)
committerAlexandre Oliva <oliva@gnu.org>
Mon, 20 Nov 2023 08:14:25 +0000 (05:14 -0300)
I've recently patched scev-3.c and scev-5.c because it only passed by
accident on ia32.  It also fails on some (but not all) arm-eabi
variants.  It seems hard to characterize the conditions in which the
optimization is supposed to pass, but expecting them to fail on ilp32
targets, though probably a little excessive and possibly noisy, is not
quite as alarming as getting a fail in test reports, so I propose
changing the xfail marker from ia32 to ilp32.

I'm also proposing to add a similar marker to scev-4.c.  Though it
doesn't appear to be failing for me, I've got reports that suggest it
still does for others, and it certainly did for us as well.

for  gcc/testsuite/ChangeLog

* gcc.dg/tree-ssa/scev-3.c: xfail on all ilp32 targets,
though some of these do pass.
* gcc.dg/tree-ssa/scev-4.c: Likewise.
* gcc.dg/tree-ssa/scev-5.c: Likewise.

gcc/testsuite/gcc.dg/tree-ssa/scev-3.c
gcc/testsuite/gcc.dg/tree-ssa/scev-4.c
gcc/testsuite/gcc.dg/tree-ssa/scev-5.c

index ac8c8d4519e302cd07a1278c4e01facdc733abcf..beea9aed9fe954bdcc4055163ab0e98abb57c63c 100644 (file)
@@ -40,4 +40,5 @@ __BB(6):
 
 }
 
-/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" { xfail ia32 } } } */
+/* Not all 32-bit systems fail this, but several do.  */
+/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" { xfail ilp32 } } } */
index 57cb02134021827049df8d047f7af392d4ad64fc..a97f75f81f65424caee516920dc44f882026f389 100644 (file)
@@ -45,4 +45,5 @@ __BB(6):
 
 }
 
-/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" } } */
+/* Not all 32-bit systems fail this, but several do.  */
+/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" { xfail ilp32 } } } */
index c911a9298866fb12c1e664bd0a89fa421c53ae9f..08f4260403c4019e90aca78de4a2d12eafbbc279 100644 (file)
@@ -40,4 +40,5 @@ __BB(6):
 
 }
 
-/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" { xfail ia32 } } } */
+/* Not all 32-bit systems fail this, but several do.  */
+/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" { xfail ilp32 } } } */