]> git.ipfire.org Git - thirdparty/kernel/stable-queue.git/commitdiff
4.4-stable patches
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 29 Dec 2019 16:09:23 +0000 (17:09 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 29 Dec 2019 16:09:23 +0000 (17:09 +0100)
added patches:
ext4-check-for-directory-entries-too-close-to-block-end.patch
mmc-sdhci-of-esdhc-fix-p2020-errata-handling.patch
powerpc-irq-fix-stack-overflow-verification.patch

queue-4.4/ext4-check-for-directory-entries-too-close-to-block-end.patch [new file with mode: 0644]
queue-4.4/mmc-sdhci-of-esdhc-fix-p2020-errata-handling.patch [new file with mode: 0644]
queue-4.4/powerpc-irq-fix-stack-overflow-verification.patch [new file with mode: 0644]
queue-4.4/series

diff --git a/queue-4.4/ext4-check-for-directory-entries-too-close-to-block-end.patch b/queue-4.4/ext4-check-for-directory-entries-too-close-to-block-end.patch
new file mode 100644 (file)
index 0000000..9f6a5f9
--- /dev/null
@@ -0,0 +1,39 @@
+From 109ba779d6cca2d519c5dd624a3276d03e21948e Mon Sep 17 00:00:00 2001
+From: Jan Kara <jack@suse.cz>
+Date: Mon, 2 Dec 2019 18:02:13 +0100
+Subject: ext4: check for directory entries too close to block end
+
+From: Jan Kara <jack@suse.cz>
+
+commit 109ba779d6cca2d519c5dd624a3276d03e21948e upstream.
+
+ext4_check_dir_entry() currently does not catch a case when a directory
+entry ends so close to the block end that the header of the next
+directory entry would not fit in the remaining space. This can lead to
+directory iteration code trying to access address beyond end of current
+buffer head leading to oops.
+
+CC: stable@vger.kernel.org
+Signed-off-by: Jan Kara <jack@suse.cz>
+Link: https://lore.kernel.org/r/20191202170213.4761-3-jack@suse.cz
+Signed-off-by: Theodore Ts'o <tytso@mit.edu>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+
+---
+ fs/ext4/dir.c |    5 +++++
+ 1 file changed, 5 insertions(+)
+
+--- a/fs/ext4/dir.c
++++ b/fs/ext4/dir.c
+@@ -75,6 +75,11 @@ int __ext4_check_dir_entry(const char *f
+               error_msg = "rec_len is too small for name_len";
+       else if (unlikely(((char *) de - buf) + rlen > size))
+               error_msg = "directory entry overrun";
++      else if (unlikely(((char *) de - buf) + rlen >
++                        size - EXT4_DIR_REC_LEN(1) &&
++                        ((char *) de - buf) + rlen != size)) {
++              error_msg = "directory entry too close to block end";
++      }
+       else if (unlikely(le32_to_cpu(de->inode) >
+                       le32_to_cpu(EXT4_SB(dir->i_sb)->s_es->s_inodes_count)))
+               error_msg = "inode out of bounds";
diff --git a/queue-4.4/mmc-sdhci-of-esdhc-fix-p2020-errata-handling.patch b/queue-4.4/mmc-sdhci-of-esdhc-fix-p2020-errata-handling.patch
new file mode 100644 (file)
index 0000000..a125e1d
--- /dev/null
@@ -0,0 +1,47 @@
+From fe0acab448f68c3146235afe03fb932e242ec94c Mon Sep 17 00:00:00 2001
+From: Yangbo Lu <yangbo.lu@nxp.com>
+Date: Mon, 16 Dec 2019 11:18:42 +0800
+Subject: mmc: sdhci-of-esdhc: fix P2020 errata handling
+
+From: Yangbo Lu <yangbo.lu@nxp.com>
+
+commit fe0acab448f68c3146235afe03fb932e242ec94c upstream.
+
+Two previous patches introduced below quirks for P2020 platforms.
+- SDHCI_QUIRK_RESET_AFTER_REQUEST
+- SDHCI_QUIRK_BROKEN_TIMEOUT_VAL
+
+The patches made a mistake to add them in quirks2 of sdhci_host
+structure, while they were defined for quirks.
+       host->quirks2 |= SDHCI_QUIRK_RESET_AFTER_REQUEST;
+       host->quirks2 |= SDHCI_QUIRK_BROKEN_TIMEOUT_VAL;
+
+This patch is to fix them.
+       host->quirks |= SDHCI_QUIRK_RESET_AFTER_REQUEST;
+       host->quirks |= SDHCI_QUIRK_BROKEN_TIMEOUT_VAL;
+
+Fixes: 05cb6b2a66fa ("mmc: sdhci-of-esdhc: add erratum eSDHC-A001 and A-008358 support")
+Fixes: a46e42712596 ("mmc: sdhci-of-esdhc: add erratum eSDHC5 support")
+Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com>
+Cc: stable@vger.kernel.org
+Link: https://lore.kernel.org/r/20191216031842.40068-1-yangbo.lu@nxp.com
+Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+
+---
+ drivers/mmc/host/sdhci-of-esdhc.c |    4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+--- a/drivers/mmc/host/sdhci-of-esdhc.c
++++ b/drivers/mmc/host/sdhci-of-esdhc.c
+@@ -625,8 +625,8 @@ static int sdhci_esdhc_probe(struct plat
+               host->quirks &= ~SDHCI_QUIRK_NO_BUSY_IRQ;
+       if (of_find_compatible_node(NULL, NULL, "fsl,p2020-esdhc")) {
+-              host->quirks2 |= SDHCI_QUIRK_RESET_AFTER_REQUEST;
+-              host->quirks2 |= SDHCI_QUIRK_BROKEN_TIMEOUT_VAL;
++              host->quirks |= SDHCI_QUIRK_RESET_AFTER_REQUEST;
++              host->quirks |= SDHCI_QUIRK_BROKEN_TIMEOUT_VAL;
+       }
+       if (of_device_is_compatible(np, "fsl,p5040-esdhc") ||
diff --git a/queue-4.4/powerpc-irq-fix-stack-overflow-verification.patch b/queue-4.4/powerpc-irq-fix-stack-overflow-verification.patch
new file mode 100644 (file)
index 0000000..bcb9561
--- /dev/null
@@ -0,0 +1,50 @@
+From 099bc4812f09155da77eeb960a983470249c9ce1 Mon Sep 17 00:00:00 2001
+From: Christophe Leroy <christophe.leroy@c-s.fr>
+Date: Mon, 9 Dec 2019 06:19:08 +0000
+Subject: powerpc/irq: fix stack overflow verification
+
+From: Christophe Leroy <christophe.leroy@c-s.fr>
+
+commit 099bc4812f09155da77eeb960a983470249c9ce1 upstream.
+
+Before commit 0366a1c70b89 ("powerpc/irq: Run softirqs off the top of
+the irq stack"), check_stack_overflow() was called by do_IRQ(), before
+switching to the irq stack.
+In that commit, do_IRQ() was renamed __do_irq(), and is now executing
+on the irq stack, so check_stack_overflow() has just become almost
+useless.
+
+Move check_stack_overflow() call in do_IRQ() to do the check while
+still on the current stack.
+
+Fixes: 0366a1c70b89 ("powerpc/irq: Run softirqs off the top of the irq stack")
+Cc: stable@vger.kernel.org
+Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
+Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
+Link: https://lore.kernel.org/r/e033aa8116ab12b7ca9a9c75189ad0741e3b9b5f.1575872340.git.christophe.leroy@c-s.fr
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+
+---
+ arch/powerpc/kernel/irq.c |    4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+--- a/arch/powerpc/kernel/irq.c
++++ b/arch/powerpc/kernel/irq.c
+@@ -484,8 +484,6 @@ void __do_irq(struct pt_regs *regs)
+       trace_irq_entry(regs);
+-      check_stack_overflow();
+-
+       /*
+        * Query the platform PIC for the interrupt & ack it.
+        *
+@@ -517,6 +515,8 @@ void do_IRQ(struct pt_regs *regs)
+       irqtp = hardirq_ctx[raw_smp_processor_id()];
+       sirqtp = softirq_ctx[raw_smp_processor_id()];
++      check_stack_overflow();
++
+       /* Already there ? */
+       if (unlikely(curtp == irqtp || curtp == sirqtp)) {
+               __do_irq(regs);
index 87ec4488cfb0a826f211a144965bd5c9ba8fbe55..98417edd54e54aeeeccfbbd5191873d7c17192ba 100644 (file)
@@ -83,3 +83,6 @@ usbip-fix-error-path-of-vhci_recv_ret_submit.patch
 usb-ehci-do-not-return-epipe-when-hub-is-disconnected.patch
 platform-x86-hp-wmi-make-buffer-for-hpwmi_feature2_query-128-bytes.patch
 staging-comedi-gsc_hpdi-check-dma_alloc_coherent-return-value.patch
+ext4-check-for-directory-entries-too-close-to-block-end.patch
+powerpc-irq-fix-stack-overflow-verification.patch
+mmc-sdhci-of-esdhc-fix-p2020-errata-handling.patch