]> git.ipfire.org Git - thirdparty/openssl.git/commitdiff
Disable stringop-overflow warnings on s390
authorNeil Horman <nhorman@openssl.org>
Thu, 3 Apr 2025 14:47:28 +0000 (10:47 -0400)
committerNeil Horman <nhorman@openssl.org>
Thu, 3 Apr 2025 14:54:31 +0000 (10:54 -0400)
Recently ci on master has been failing:
https://github.com/openssl/openssl/actions/runs/14234051502/job/39919663876

Its occuring because the s390 gcc compiler is complaining about various
functions attempting to write past the end of an array.

However, I can find no case in which we actually do so in this case.

The problem resolves when we either:
1) Disable the stringop-overflow warning
or
2) disable all loop unrolling optimizations with fno-loop-nest-optimize

Given that asan doesn't report any out of bounds errors on s390 when
built with case (1), and case (2) can be a significant performance hit,
coupled with the fact that gcc on any other platform avoids the same
issue (s390 is stuck on gcc 12, instead of gcc 16 where the other
platforms are), I think the right thing to do is just disable the
warning here

Reviewed-by: Kurt Roeckx <kurt@roeckx.be>
Reviewed-by: Tim Hudson <tjh@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/27253)

.github/workflows/os-zoo.yml

index 70ea629788a2f5c61557be4c2cebb0b6408878d8..dc827974c1ef7639ee4c5ecd3cafb2101215ec28 100644 (file)
@@ -196,7 +196,7 @@ jobs:
     steps:
     - uses: actions/checkout@v4
     - name: config
-      run: ./config --strict-warnings enable-fips enable-md2 enable-rc5 enable-ssl3 enable-ssl3-method enable-trace
+      run: ./config --strict-warnings -Wno-stringop-overflow enable-fips enable-md2 enable-rc5 enable-ssl3 enable-ssl3-method enable-trace
     - name: config dump
       run: ./configdata.pm --dump
     - name: make