]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
net: stmmac: sunxi: use devm_stmmac_pltfr_probe()
authorRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Tue, 15 Apr 2025 12:58:10 +0000 (13:58 +0100)
committerJakub Kicinski <kuba@kernel.org>
Fri, 18 Apr 2025 01:41:40 +0000 (18:41 -0700)
Using devm_stmmac_pltfr_probe() simplifies the probe function. This
will not only call plat_dat->init (sun7i_dwmac_init), but also
plat_dat->exit (sun7i_dwmac_exit) appropriately if stmmac_dvr_probe()
fails. This results in an overall simplification of the glue driver.

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link: https://patch.msgid.link/E1u4fre-000nMr-FT@rmk-PC.armlinux.org.uk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/stmicro/stmmac/dwmac-sunxi.c

index 665eab1d340911015d20a1175070f9b82b5f3cad..1eadcf5d1ad6322cc86e5b1da8aeeb12f9c88d45 100644 (file)
@@ -144,7 +144,7 @@ static int sun7i_gmac_probe(struct platform_device *pdev)
        plat_dat->tx_fifo_size = 4096;
        plat_dat->rx_fifo_size = 16384;
 
-       return stmmac_pltfr_probe(pdev, plat_dat, &stmmac_res);
+       return devm_stmmac_pltfr_probe(pdev, plat_dat, &stmmac_res);
 }
 
 static const struct of_device_id sun7i_dwmac_match[] = {
@@ -155,7 +155,6 @@ MODULE_DEVICE_TABLE(of, sun7i_dwmac_match);
 
 static struct platform_driver sun7i_dwmac_driver = {
        .probe  = sun7i_gmac_probe,
-       .remove = stmmac_pltfr_remove,
        .driver = {
                .name           = "sun7i-dwmac",
                .pm             = &stmmac_pltfr_pm_ops,